Closed Bug 785467 Opened 7 years ago Closed 6 years ago

Ion: Implement IC for sets on DOM proxies in IonMonkey

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: bzbarsky, Assigned: efaust)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Similar to bug 785465, but for set, not get.  This is relevant for CSSStyleDeclaration, where setting .style.foo is pretty common.

I _think_ a setup similar to the get IC should work ok here, but I'm not an expert on this stuff.
Whiteboard: [js:t]
Depends on: 824393
Assignee: general → efaustbmo
Status: NEW → ASSIGNED
Depends on: 904827
Depends on: 907422
It's a little silly to have these now that we have generic proxy stubs, but since we can't distinguish shadowed from unshadowed DOM proxies easily at runtime without the call, it's hard to only skim off the non-shadowing ones. Perhaps we should guard on some nature of the exando slot instead?
Attachment #795845 - Flags: review?(kvijayan)
Attachment #795845 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/mozilla-central/rev/2711ef193eb7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.