Closed
Bug 785467
Opened 14 years ago
Closed 13 years ago
Ion: Implement IC for sets on DOM proxies in IonMonkey
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bzbarsky, Assigned: efaust)
References
(Blocks 1 open bug)
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
7.77 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 785465, but for set, not get. This is relevant for CSSStyleDeclaration, where setting .style.foo is pretty common.
I _think_ a setup similar to the get IC should work ok here, but I'm not an expert on this stuff.
|
Reporter | |
Updated•14 years ago
|
Blocks: ParisBindings
|
|
||
Updated•14 years ago
|
Whiteboard: [js:t]
|
Assignee | |
Updated•13 years ago
|
Assignee: general → efaustbmo
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
It's a little silly to have these now that we have generic proxy stubs, but since we can't distinguish shadowed from unshadowed DOM proxies easily at runtime without the call, it's hard to only skim off the non-shadowing ones. Perhaps we should guard on some nature of the exando slot instead?
Attachment #795845 -
Flags: review?(kvijayan)
|
|
||
Updated•13 years ago
|
Attachment #795845 -
Flags: review?(kvijayan) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•