Closed Bug 785485 Opened 8 years ago Closed 8 years ago

No way to clear "Open this page with an app" permissions granted from doorhanger notifications

Categories

(Firefox for Android :: General, defect)

17 Branch
ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 18
Tracking Status
firefox17 --- affected

People

(Reporter: mcomella, Assigned: Margaret)

Details

Attachments

(2 files)

Doorhangers prompt users, "Don't ask again for this site". However, there appears to be no way to clear this setting.

The best place to do this would probably be in the "Site Settings..." dialog (long press the URL bar, select "Site Settings..."). This is currently the location where site settings are cleared for saving passwords.
The settings for geolocation and offline storage should also be in the "Site Settings..." dialog. Are they not? When we discussed this on IRC, I thought it was just helper apps permissions that couldn't be reset.

I think the point of this bug should be to audit the doorhangers that offer to set permissions and make sure there's a way to clear them.

Ideally, in the long run, it would be nice to incorporate these permissions into a generic site settings/doorhanger notifications panel that can be opened from the favicion. I think Ian has a plan for this, but in the mean time, we should make sure users can clear permissions.
Summary: No way to clear doorhanger settings → No way to clear some permissions granted from doorhanger notifications
(In reply to Margaret Leibovic [:margaret] from comment #1)
> The settings for geolocation and offline storage should also be in the "Site
> Settings..." dialog. Are they not?

My mistake. It appears geolocation, offline storage, password memorization, and playing plugin content are all able to be cleared. However, you can't clear the "Open this page with an app" setting (ex: marketplace.mozilla.org). Changed this bug title to handle this behavior.

> ...it was just helper apps permissions that couldn't be reset.

By helper apps, do you mean the web apps you can install into Firefox?

If so, then yes, as far as I know, you can't clear these permissions, though I assume uninstalling and reinstalling the app would do the trick. Created bug 785932 for this.
Summary: No way to clear some permissions granted from doorhanger notifications → No way to clear "Open this page with an app" permissions granted from doorhanger notifications
(In reply to Michael Comella (:mcomella) from comment #2)

> > ...it was just helper apps permissions that couldn't be reset.
> 
> By helper apps, do you mean the web apps you can install into Firefox?

Helper apps is the term we use for the "Open this page with an app" functionality :)

> If so, then yes, as far as I know, you can't clear these permissions, though
> I assume uninstalling and reinstalling the app would do the trick. Created
> bug 785932 for this.

Good catch. I wonder what kind of UI we should make to deal with that.
I think we can just add "native-intent" to the list of perms we check/clear
Assignee: nobody → margaret.leibovic
Attached patch patchSplinter Review
I think this should do the trick, although I'm a bit unsure of the best strings to use to describe these permissions. I went with "Always"/"Never", so the UI will show "Open With an App: Always" and "Open With an App: Never" as the set permissions.

Michael, do you have a page to test this with?
Attachment #655760 - Flags: review?(michael.l.comella)
Comment on attachment 655760 [details] [diff] [review]
patch

Review of attachment 655760 [details] [diff] [review]:
-----------------------------------------------------------------

As a side note, the "Open with an App" doorhanger interaction feels a bit strange to me – see bug 785547.

However, this patch LGTM, including the "Always/Never" strings.

For testing, I don't have a custom page but I believe you can use marketplace.mozilla.org which uses the Marketplace app.
Attachment #655760 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #6)
 
> For testing, I don't have a custom page but I believe you can use
> marketplace.mozilla.org which uses the Marketplace app.

Yup, that worked, thanks.
https://hg.mozilla.org/mozilla-central/rev/386e9555a105
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified fixed:

Build: Firefox 18.0a1 (2012-09-18)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.