Some of charset menu strings have to move from .property to .js

NEW
Assigned to

Status

()

Core
Internationalization
P3
normal
17 years ago
8 years ago

People

(Reporter: nhottanscp, Assigned: smontagu)

Tracking

({l12y})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

17 years ago
Some charset menu resources are consistent through localized builds and do not
have to be located in navigtor.properties. Having them in .property
files causes a maintenance problem as we have both mozilla and netscape versions
of navigator.properties.

List of strings which need to move:
intl.charsetmenu.browser.more1
intl.charsetmenu.browser.more2
intl.charsetmenu.browser.more3
intl.charsetmenu.browser.more4
intl.charsetmenu.browser.more5
intl.charsetmenu.mailedit

Comment 1

17 years ago
This will fix it for the non-localizable resources, but even the localized
resources should not live in multiple versions (e.g., mozilla and netscape)
of the same file.
(Reporter)

Comment 2

17 years ago
I don't know about the original design, cc to tao.

Comment 3

17 years ago
Cata was the original author. IMO, move them into non-vendor files should be
enough; don't move them back to *.js.
(Reporter)

Comment 4

17 years ago
Tao, what do you mean by non-vendor files?

Comment 5

17 years ago
What I meant was files in mozilla that won't get overridden by netsccape's.
(Reporter)

Comment 6

17 years ago
Do you have a suggestion? I am not familiar which files are available.
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: l12y
Target Milestone: --- → Future
(Reporter)

Updated

17 years ago
Target Milestone: Future → ---

Comment 7

17 years ago
Switching qa contact to jonrubin.
QA Contact: andreasb → jonrubin

Comment 8

17 years ago
Naoki:


If you are sure that we'll never need to localize these entries, yes, please
move them back to *.js and put some comments there.

thx

Updated

17 years ago
Keywords: nsBranch
I can take this while nhotta is gone...
Assignee: nhotta → jbetak
Status: ASSIGNED → NEW

Comment 10

17 years ago
mass change, switching qa contact from jonrubin to ruixu.
QA Contact: jonrubin → ruixu
I believe we can't really move this into JS. Cata is reading these property 
files from the charset menu C++ backend and changing that would be an 
unnecessary risk at this point.

I agree with Tao's position though: we could move all these into a .properties 
file, which is - unlike navigator.properties - not present in both Mozilla and 
Netscape. This would be reasonable even in the short term, however I'd suggest 
doing it later on the trunk do diminish the risk of regressions on the trunk.

http://lxr.mozilla.org/seamonkey/search?string=intl.charsetmenu.browser.mo
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.5

Updated

16 years ago
Blocks: 99171
> causes a maintenance problem 

the original complaint was about increased maintenance by having both open-
source and commercial versions of these strings. I believe the best course of 
action would be to move all offending entries to a .properties file, which is 
not overridden by a commercial version and exists only once. An example of such 
a file would be metadata.properties.

http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/locale/en-
US/metadata.properties

I also happen to believe that currently there is no really suitable .properties 
file and we might end up creating a new one, which would just contain the 
charset menu strings. I'll create a patch pursuing this.

Since this issue is a technicality and doesn't impede the localizability in any 
way, I'd suggest dropping the branch checkin requirement.


Comment 13

16 years ago
minusing, too late for 0.9.4
Keywords: nsbranch → nsbranch-
I don't have a good non-vendor-specific place to hold charset menu strings, but 
hope to change the way things work in a larger regesign of the charset menu.
Target Milestone: mozilla0.9.5 → Future

Updated

16 years ago
Blocks: 107067

Updated

16 years ago
Keywords: nsbranch-

Comment 15

16 years ago
Nominating nsbeta1. Would like to see this get fixed for MachV. 
cc. rchen, yxia
Keywords: nsbeta1

Comment 16

16 years ago
jbetak's contract is up. Bulk move bugs to ftang
Assignee: jbetak → ftang
Status: ASSIGNED → NEW

Updated

16 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 17

16 years ago
nsbeta1-
this does not benefit l10n, helps i18n when adding new charset support
Keywords: nsbeta1 → nsbeta1-

Comment 18

13 years ago
-> to default owner (rather than ftang's WONTFIX)
Assignee: ftang → smontagu
Status: ASSIGNED → NEW
QA Contact: ruixu → amyy
Target Milestone: Future → ---
QA Contact: amyy → i18n
You need to log in before you can comment on or make changes to this bug.