Closed Bug 785520 Opened 12 years ago Closed 12 years ago

Firefox does not scroll screen to show cursor for contenteditable elements

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

Product:
Firefox for Android Graveyard
Component:
Toolbar
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 18

People

(Reporter: brian.j.suh, Assigned: kats)

Details

Attachments

(1 file)

Patch
1.29 KB, patch
cwiiis
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.83 Safari/537.1

Steps to reproduce:

Go to http://html5demos.com/contenteditable
Click on the contenteditable element


Actual results:

Android software keyboard covers up contenteditable element and the blinking text cursor.


Expected results:

The website is scrolled so that the blinking text cursor is visible within the lessened screen space, which is the same behavior that occurs for input box elements.
OS: Windows 7 → Android
Hardware: x86_64 → ARM
Component: General → Keyboards and IME
Grabbing this bug; the scrollToFocusedInput code in browser.js needs to be updated to also check for contenteditable instead of just HTMLInputElement and HTMLTextAreaElement. I should get around to it in the next couple of days if nobody else does it first.
Component: Keyboards and IME → Graphics, Panning and Zooming
Assignee: nobody → bugmail.mozilla
Attached patch Patch — — Splinter Review 

        Attachment #655593 -
        Flags: review?(chrislord.net)
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  
Comment on attachment 655593 [details] [diff] [review]
Patch

Review of attachment 655593 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

        Attachment #655593 -
        Flags: review?(chrislord.net) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1bbd00797432
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18

    
    

    
  
Verified fixed on: 

Build: Firefox 18.0a1 (2012-09-17)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1
Status: RESOLVED → VERIFIED

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: