Don't allow deletion of doctype nodes in the markup panel

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dcamp, Assigned: dcamp)

Tracking

13 Branch
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 655180 [details] [diff] [review]
v1

This patch prevents deletion of the doctype tag, and moves protection of other tags from the delete key handler to the deleteNode method.
Attachment #655180 - Flags: review?(jwalker)
Attachment #655180 - Flags: review?(jwalker) → review+
Added dependency
Blocks: 785380
(Assignee)

Comment 2

5 years ago
Created attachment 655234 [details] [diff] [review]
patch to land

Brought in the fix to this patch from bug 785380.
Attachment #655180 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/4c3e82b3dcaf
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 4

5 years ago
Created attachment 655260 [details] [diff] [review]
bustage fix

I didn't move the fix over from 785380 correctly.  I landed this fix with r=jwalker, since it's what he reviewed over on bug 785380.

https://hg.mozilla.org/integration/fx-team/rev/5fa145ef906a
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4c3e82b3dcaf
https://hg.mozilla.org/mozilla-central/rev/5fa145ef906a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.