Closed
Bug 785528
Opened 12 years ago
Closed 12 years ago
Don't allow deletion of doctype nodes in the markup panel
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(2 files, 1 obsolete file)
|
1.81 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.04 KB,
patch
|
Details | Diff | Splinter Review |
This patch prevents deletion of the doctype tag, and moves protection of other tags from the delete key handler to the deleteNode method.
Attachment #655180 -
Flags: review?(jwalker)
|
||
Updated•12 years ago
|
Attachment #655180 -
Flags: review?(jwalker) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Brought in the fix to this patch from bug 785380.
Attachment #655180 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4c3e82b3dcaf
Whiteboard: [fixed-in-fx-team]
|
|
Assignee | |
Comment 4•12 years ago
|
||
I didn't move the fix over from 785380 correctly. I landed this fix with r=jwalker, since it's what he reviewed over on bug 785380. https://hg.mozilla.org/integration/fx-team/rev/5fa145ef906a
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c3e82b3dcaf https://hg.mozilla.org/mozilla-central/rev/5fa145ef906a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•