78557 - cleanup of nsSelection.cpp

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P3)

Description

[Kathleen :Brade]

nsSelection.cpp currently has an #ifdef for _WIN32 where we are attempting (???) 
to hardcode keybindings.  We should either remove the ifdef or add a comment as 
to why having the altkey pressed is bad as well as adding any other platform-
specific code for Linux and Macintosh.

Comment 1

[rubydoo123]

moving out ot 1.0, this one can wait until then

Comment 2

[anthonyd]

well, they are there, but its not hardcoding the keybinding, it looks like it is 
double checking the keybinding for windows.  is this the same one kathy?

anthonyd

Comment 3

[anthonyd]

moving to 0.9.3 to get selection cleaned up if this is still a valid issue.

anthonyd

Comment 4

[rubydoo123]

back to 1.0

Comment 5

[rubydoo123]

--> mjudge

Comment 6

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 7

[Blake Ross]

changing selection qa to tpreston.

Comment 8

[Vedran Miletic]

retargeting

Comment 9

[Wayne Mery (:wsmwk)]

does this still have any value?

Comment 10

[Kathleen :Brade]

Yes this bug is still valid.  The #ifdef is still in the file.  The comment
above the #ifdef includes:
 //XXX Need xp way get platfrom specific behavior into key navigation.

I am happy if the #ifdef is removed (if that doesn't cause problems for Windows???).

This bug should be reassigned to someone who is willing to work on it.

Comment 11

[Uri Bernstein]

This code was removed in Bug 330305.