Lightning Calendar/Task icons don't show up in the SeaMonkey All-Tabs popup menu.

RESOLVED FIXED in 1.9

Status

Calendar
Lightning: SeaMonkey Integration
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

unspecified
x86_64
Windows 7

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
SeaMonkey uses a different rule to find icons for the Alltabs menu. Patch coming up.
(Assignee)

Comment 1

5 years ago
Created attachment 655264 [details] [diff] [review]
Patch v1.0 Add Lightning icons to the Alltabs menu.

This should be safe, these rules don't match anything in Thunderbird.
Attachment #655264 - Flags: review?(philipp)
(Assignee)

Updated

5 years ago
Attachment #655264 - Attachment is patch: true
(Assignee)

Updated

5 years ago
Depends on: 464524
(Assignee)

Updated

5 years ago
Attachment #655264 - Flags: feedback?(richard.marti)
Comment on attachment 655264 [details] [diff] [review]
Patch v1.0 Add Lightning icons to the Alltabs menu.

.icon-holder isn't used in TB. This should safe to use.

You have only code for Windows. Linux and OSX don't need icons?
Attachment #655264 - Flags: feedback?(richard.marti) → feedback+
(Assignee)

Comment 3

5 years ago
I can't test on Linux/OS X. I'll attach a patch that includes those but obviously untested.
(Assignee)

Comment 4

5 years ago
Comment on attachment 655264 [details] [diff] [review]
Patch v1.0 Add Lightning icons to the Alltabs menu.

New patch coming up.
Attachment #655264 - Flags: review?(philipp)
(Assignee)

Comment 5

5 years ago
Created attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

> You have only code for Windows. Linux and OSX don't need icons?
Fix Linux and OS X as well.
Attachment #655264 - Attachment is obsolete: true
Attachment #655323 - Flags: review?(philipp)
Attachment #655323 - Flags: feedback?(richard.marti)
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

This looks good for me but I don't use SM and can't say if it works.
Attachment #655323 - Flags: feedback?(richard.marti) → feedback+
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

r=philipp
Attachment #655323 - Flags: review?(philipp) → review+
(Assignee)

Comment 8

5 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/404b3c94f8b7
(Assignee)

Comment 9

5 years ago
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

This is just a minor cosmetic issue so not really necessary for tb17/sm2.14 but asking anyway.
Attachment #655323 - Flags: approval-calendar-aurora?
Target Milestone: --- → 2.0
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

I guess you can do that, I don't think it will break anything. Set target to 1.9 after you push.
Attachment #655323 - Flags: approval-calendar-aurora? → approval-calendar-aurora+
(Assignee)

Comment 11

5 years ago
Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/e1f614c58463
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: 2.0 → 1.9
You need to log in before you can comment on or make changes to this bug.