Closed Bug 785580 Opened 7 years ago Closed 7 years ago

Lightning Calendar/Task icons don't show up in the SeaMonkey All-Tabs popup menu.

Categories

(Calendar :: Lightning: SeaMonkey Integration, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file, 1 obsolete file)

SeaMonkey uses a different rule to find icons for the Alltabs menu. Patch coming up.
This should be safe, these rules don't match anything in Thunderbird.
Attachment #655264 - Flags: review?(philipp)
Attachment #655264 - Attachment is patch: true
Depends on: 464524
Attachment #655264 - Flags: feedback?(richard.marti)
Comment on attachment 655264 [details] [diff] [review]
Patch v1.0 Add Lightning icons to the Alltabs menu.

.icon-holder isn't used in TB. This should safe to use.

You have only code for Windows. Linux and OSX don't need icons?
Attachment #655264 - Flags: feedback?(richard.marti) → feedback+
I can't test on Linux/OS X. I'll attach a patch that includes those but obviously untested.
Comment on attachment 655264 [details] [diff] [review]
Patch v1.0 Add Lightning icons to the Alltabs menu.

New patch coming up.
Attachment #655264 - Flags: review?(philipp)
> You have only code for Windows. Linux and OSX don't need icons?
Fix Linux and OS X as well.
Attachment #655264 - Attachment is obsolete: true
Attachment #655323 - Flags: review?(philipp)
Attachment #655323 - Flags: feedback?(richard.marti)
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

This looks good for me but I don't use SM and can't say if it works.
Attachment #655323 - Flags: feedback?(richard.marti) → feedback+
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

r=philipp
Attachment #655323 - Flags: review?(philipp) → review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/404b3c94f8b7
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

This is just a minor cosmetic issue so not really necessary for tb17/sm2.14 but asking anyway.
Attachment #655323 - Flags: approval-calendar-aurora?
Target Milestone: --- → 2.0
Comment on attachment 655323 [details] [diff] [review]
Patch v1.1 Fix gnomestripe and pinstripe as well.

I guess you can do that, I don't think it will break anything. Set target to 1.9 after you push.
Attachment #655323 - Flags: approval-calendar-aurora? → approval-calendar-aurora+
Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/e1f614c58463
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: 2.0 → 1.9
You need to log in before you can comment on or make changes to this bug.