Last Comment Bug 785581 - Add in ID to the Web Development menu separator to make it easier for extensions to hook into our Tools menu.
: Add in ID to the Web Development menu separator to make it easier for extensi...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.14
Assigned To: Philip Chee
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-24 21:11 PDT by Philip Chee
Modified: 2012-08-25 08:39 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1.0 Use the same ID as Firefox "devToolsSeparator" (1.43 KB, patch)
2012-08-24 21:15 PDT, Philip Chee
iann_bugzilla: review+
Details | Diff | Splinter Review

Description Philip Chee 2012-08-24 21:11:07 PDT

    
Comment 1 Philip Chee 2012-08-24 21:15:02 PDT
Created attachment 655265 [details] [diff] [review]
Patch v1.0 Use the same ID as Firefox "devToolsSeparator"

Use the same ID as Firefox: <menuseparator id="devToolsSeparator"/>
Comment 2 Ian Neal (Away until 7th Aug) 2012-08-25 06:51:29 PDT
Comment on attachment 655265 [details] [diff] [review]
Patch v1.0 Use the same ID as Firefox "devToolsSeparator"

Is it worth looking at changing the <menupopup id="toolsPopup"> id to "menu_ToolsPopup" in a separate bug?
Comment 3 Philip Chee 2012-08-25 08:19:24 PDT
> Is it worth looking at changing the <menupopup id="toolsPopup"> id to
> "menu_ToolsPopup" in a separate bug?
Unfortunately our "toolsPopup" corresponds to the Firefox "menuWebDeveloperPopup"
and it's our "taskPopup" that is the equivalent of the Firefox "menu_ToolsPopup"
I'd say shuffling these around will cause more problems that it will fix.
Comment 4 Philip Chee 2012-08-25 08:39:05 PDT
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/54721b83aff8

Note You need to log in before you can comment on or make changes to this bug.