785596 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoAppShell$10.run(GeckoAppShell.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It's a low volume crash but there's a spike in crashes starting from 17.0a1/20120824. It has been hit by 10 users in less than one day.
The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5650196a8c7d&tochange=1c0ac073dc65

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoAppShell$10.run(GeckoAppShell.java:1505)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4511)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:980)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:747)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoAppShell%2410.run%28GeckoAppShell.java%29

Comment 1

[Kartikaya Gupta (email:[e-mail])]

GeckoApp.mAppContext.getLayerView() is returning null, probably because of an activity restart. This is likely a regression from bug 781220. Patch coming shortly.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 655590 [details] [diff] [review]
Patch

Review of attachment 655590 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7e7eb166dd9

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c7e7eb166dd9

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Looks like this missed the merge, let's get an uplift nomination and land to Aurora.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 655590 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 781220
User impact if declined: low-volume crash
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile-only, low-risk
String or UUID changes made by this patch: none

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fdae50d997d0

Comment 9

[Cristian Nicolae (:xti)]

Latest crash on Aurora channel was on 2012-09-14 with the following build id: 20120903042010 which doesn't contain the patch. There is no crash on Nightly. It seems that the bug was fixed. Closing it as verified fixed