785632 - Remove the permission manager workaround for Gaia

Status: RESOLVED FIXED

(Core :: General, defect, P1)

Description

[Mounir Lamouri (:mounir)]

This bug is about reverting bug 785631 so bug 777072 is fully working.

The idea, as explained in bug 785631 is to allow users/developers to update their profile between the landing of bug 785631 and this one.

Comment 1

[Andrew Overholt [:overholt]]

Seems important for Basecamp so +ing.

Comment 2

[Mounir Lamouri (:mounir)]

I think we should have this being WebAPI:P1 because that means any app will have access to permissions from the default app (appId=0). This seems scary unless we are 100% sure that the default app has no permissions at all.

Comment 3

[Justin Lebar (not reading bugmail)]

(In reply to Mounir Lamouri (:mounir) from comment #2)
> I think we should have this being WebAPI:P1 because that means any app will
> have access to permissions from the default app (appId=0). This seems scary
> unless we are 100% sure that the default app has no permissions at all.

Done.

Comment 4

[Mounir Lamouri (:mounir)]

Given that this is a bug and not a feature, I will work on that after feature freeze.

Comment 5

[Mounir Lamouri (:mounir)]

I have sent a Gaia pull request to use a newer xulrunner build so the correct permission info will be generated:
https://github.com/mozilla-b2g/gaia/pull/5137

Comment 6

[Mounir Lamouri (:mounir)]

I'm working on this earlier than expected because it seems like Etienne was running into bugs with permissions and that might likely be related (given that Gaia had no real per-app permissions). With this patch and the PR, things should be normal.

Comment 7

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 8

[Mounir Lamouri (:mounir)]

FWIW, Gaia pull request has landed, this can safely land now (as long as developers update the gaia repo).

Comment 9

[Mounir Lamouri (:mounir)]

Also, email sent to dev-gaia so they will have their xulrunners updated before this patch lands.

Comment 10

[Justin Lebar (not reading bugmail)]

Comment on attachment 664461 [details] [diff] [review]
Patch

r=incredibly-me.

Comment 11

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7de3b05cd7d8

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Mounir Lamouri (:mounir) from comment #8)
> FWIW, Gaia pull request has landed, this can safely land now (as long as
> developers update the gaia repo).

(In reply to Mounir Lamouri (:mounir) from comment #9)
> Also, email sent to dev-gaia so they will have their xulrunners updated
> before this patch lands.

That was not even 1% of the work needed here.  Your pull request even broke gaia, before this patch landed.

This patch is going to have to come out again.  This time though, we know what's needed to fix it up, since we took the time to test it while inbound was closed.

I don't know how many times I need to say this, but while we're all twiddling our fingers waiting on testing on infra, just ASK ME to test locally, instead of breaking a product days before feature freeze.

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I think we should be able to reland this tomorrow.

Comment 14

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Backed out, sorry

https://hg.mozilla.org/integration/mozilla-inbound/rev/90ff76b2032e

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I won't take credit for all the work you've done.

Comment 16

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I had a workaround for preinstalled apps in gaia, but it epically breaks "eng" builds.  So need to do this right.

Comment 17

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Fabrice, how do you feel about adding a build/permissions.js hack to work around the pre-installed DB problem, temporarily?

Comment 18

[[:fabrice] Fabrice Desré]

Which kind of hack are you thinking about? I have a patch almost ready in bug 787439 to populate the permission db at startup, but I only tested with VARIANT=user builds for now.

Comment 19

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Ah, great news!  (You don't want to know what hack I had in mind ;) .)

Comment 20

[Mounir Lamouri (:mounir)]

I got a green light from Fabrice yesterday.

Re-landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7be3bc10c58

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7be3bc10c58

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e9d90b26e252