Closed Bug 785642 Opened 10 years ago Closed 10 years ago

Return failure from nsDocShell::CaptureState if SaveWindowState returns null

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Patch v1
724 bytes, patch
mrbkap
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
I prefer keeping functional changes in separate bugs, especially if I don't understand the effects :)
Attachment #655341 - Flags: review?(mrbkap)
Comment on attachment 655341 [details] [diff] [review]
Patch v1

I'd prefer either an explicit if/return (as just above) or NS_ENSURE_TRUE. r=me with that.
Attachment #655341 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/42e9a4b8dc3e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.