Closed Bug 785657 Opened 7 years ago Closed 7 years ago

Enable async animations in content processes

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #655358 - Flags: review?(jones.chris.g)
Comment on attachment 655358 [details] [diff] [review]
Patch

>diff --git a/gfx/layers/ipc/CompositorChild.h b/gfx/layers/ipc/CompositorChild.h
 
>+  static bool HasCompositor() { return sCompositor != nullptr; }

Call this |ChildProcessHasCompositor()|, since this check is only
meaningful in subprocesses.

>diff --git a/gfx/thebes/gfxPlatform.cpp b/gfx/thebes/gfxPlatform.cpp

>+bool
>+gfxPlatform::OffMainThreadCompositingEnabled()
>+{
>+  return XRE_GetProcessType() == GeckoProcessType_Default ?
>+    CompositorParent::CompositorLoop != nullptr

Um?  itym |CompositorParent::CompositorLoop()| ;).

Looks OK, but please test.

r=me with the fixes above.
Attachment #655358 - Flags: review?(jones.chris.g) → review+
(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)

> 
> Um?  itym |CompositorParent::CompositorLoop()| ;).

Wow, that's the second time I've done this today.  Good catch.
https://hg.mozilla.org/mozilla-central/rev/90c92e55affd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
I'm a little surprised this was turned on when we still don't have any automated tests for it.
You need to log in before you can comment on or make changes to this bug.