785657 - Enable async animations in content processes

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 655358 [details] [diff] [review]
Patch

>diff --git a/gfx/layers/ipc/CompositorChild.h b/gfx/layers/ipc/CompositorChild.h
 
>+  static bool HasCompositor() { return sCompositor != nullptr; }

Call this |ChildProcessHasCompositor()|, since this check is only
meaningful in subprocesses.

>diff --git a/gfx/thebes/gfxPlatform.cpp b/gfx/thebes/gfxPlatform.cpp

>+bool
>+gfxPlatform::OffMainThreadCompositingEnabled()
>+{
>+  return XRE_GetProcessType() == GeckoProcessType_Default ?
>+    CompositorParent::CompositorLoop != nullptr

Um?  itym |CompositorParent::CompositorLoop()| ;).

Looks OK, but please test.

r=me with the fixes above.

Comment 2

[David Zbarsky (:dzbarsky)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)

> 
> Um?  itym |CompositorParent::CompositorLoop()| ;).

Wow, that's the second time I've done this today.  Good catch.

Comment 3

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90c92e55affd

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90c92e55affd

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm a little surprised this was turned on when we still don't have any automated tests for it.