Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Enable async animations in content processes

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 655358 [details] [diff] [review]
Patch
Attachment #655358 - Flags: review?(jones.chris.g)
Comment on attachment 655358 [details] [diff] [review]
Patch

>diff --git a/gfx/layers/ipc/CompositorChild.h b/gfx/layers/ipc/CompositorChild.h
 
>+  static bool HasCompositor() { return sCompositor != nullptr; }

Call this |ChildProcessHasCompositor()|, since this check is only
meaningful in subprocesses.

>diff --git a/gfx/thebes/gfxPlatform.cpp b/gfx/thebes/gfxPlatform.cpp

>+bool
>+gfxPlatform::OffMainThreadCompositingEnabled()
>+{
>+  return XRE_GetProcessType() == GeckoProcessType_Default ?
>+    CompositorParent::CompositorLoop != nullptr

Um?  itym |CompositorParent::CompositorLoop()| ;).

Looks OK, but please test.

r=me with the fixes above.
Attachment #655358 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)

> 
> Um?  itym |CompositorParent::CompositorLoop()| ;).

Wow, that's the second time I've done this today.  Good catch.
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/90c92e55affd
https://hg.mozilla.org/mozilla-central/rev/90c92e55affd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
I'm a little surprised this was turned on when we still don't have any automated tests for it.
You need to log in before you can comment on or make changes to this bug.