Last Comment Bug 785657 - Enable async animations in content processes
: Enable async animations in content processes
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: David Zbarsky (:dzbarsky)
Depends on:
  Show dependency treegraph
Reported: 2012-08-25 14:48 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-08-28 15:05 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (6.71 KB, patch)
2012-08-25 14:48 PDT, David Zbarsky (:dzbarsky)
cjones.bugs: review+
Details | Diff | Review

Description David Zbarsky (:dzbarsky) 2012-08-25 14:48:05 PDT
Created attachment 655358 [details] [diff] [review]
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 17:08:37 PDT
Comment on attachment 655358 [details] [diff] [review]

>diff --git a/gfx/layers/ipc/CompositorChild.h b/gfx/layers/ipc/CompositorChild.h
>+  static bool HasCompositor() { return sCompositor != nullptr; }

Call this |ChildProcessHasCompositor()|, since this check is only
meaningful in subprocesses.

>diff --git a/gfx/thebes/gfxPlatform.cpp b/gfx/thebes/gfxPlatform.cpp

>+  return XRE_GetProcessType() == GeckoProcessType_Default ?
>+    CompositorParent::CompositorLoop != nullptr

Um?  itym |CompositorParent::CompositorLoop()| ;).

Looks OK, but please test.

r=me with the fixes above.
Comment 2 David Zbarsky (:dzbarsky) 2012-08-25 18:14:21 PDT
(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)

> Um?  itym |CompositorParent::CompositorLoop()| ;).

Wow, that's the second time I've done this today.  Good catch.
Comment 3 David Zbarsky (:dzbarsky) 2012-08-25 18:28:16 PDT
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-26 13:06:19 PDT
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-08-27 23:57:18 PDT
I'm a little surprised this was turned on when we still don't have any automated tests for it.

Note You need to log in before you can comment on or make changes to this bug.