Closed
Bug 785666
Opened 12 years ago
Closed 12 years ago
[CC] Get rid of old-style Suspect and Forget
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
11.85 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I suppose in theory this could cause problems for binary addons, but this code is totally untested, so any such users should switch over to Suspect2 and Forget2.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 655390 [details] [diff] [review] WIP Try run looked okay. https://tbpl.mozilla.org/?tree=Try&rev=9dd920702889
Attachment #655390 -
Flags: review?(bugs)
Comment 3•12 years ago
|
||
Comment on attachment 655390 [details] [diff] [review] WIP Ask review also from bsmedberg
Attachment #655390 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #655390 -
Flags: review?(benjamin)
Comment 4•12 years ago
|
||
Comment on attachment 655390 [details] [diff] [review] WIP So hrm, the only part of this that's maybe a problem is the XPCOMFunctions/kFrozenFunctions bit. Nobody is *supposed* to be using that struct across versions any more, but I bet they are. I'm pretty sure nobody is going to be using these specific functions, though. I think it would be better to keep those functions declared and just make them NULL in the struct, which avoids rearranging all the following functions.
Attachment #655390 -
Flags: review?(benjamin) → review-
Assignee | ||
Comment 5•12 years ago
|
||
Thanks, that makes sense.
Assignee: nobody → continuation
Attachment #655390 -
Attachment is obsolete: true
Attachment #655641 -
Flags: review?(benjamin)
Updated•12 years ago
|
Attachment #655641 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5dee7e43fa
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0a5dee7e43fa
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•