If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[CC] Get rid of old-style Suspect and Forget

RESOLVED FIXED in mozilla18

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

11.85 KB, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
I suppose in theory this could cause problems for binary addons, but this code is totally untested, so any such users should switch over to Suspect2 and Forget2.
(Assignee)

Updated

5 years ago
Blocks: 749370
(Assignee)

Comment 1

5 years ago
Created attachment 655390 [details] [diff] [review]
WIP
(Assignee)

Comment 2

5 years ago
Comment on attachment 655390 [details] [diff] [review]
WIP

Try run looked okay.

https://tbpl.mozilla.org/?tree=Try&rev=9dd920702889
Attachment #655390 - Flags: review?(bugs)
Comment on attachment 655390 [details] [diff] [review]
WIP

Ask review also from bsmedberg
Attachment #655390 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Attachment #655390 - Flags: review?(benjamin)

Comment 4

5 years ago
Comment on attachment 655390 [details] [diff] [review]
WIP

So hrm, the only part of this that's maybe a problem is the XPCOMFunctions/kFrozenFunctions bit. Nobody is *supposed* to be using that struct across versions any more, but I bet they are. I'm pretty sure nobody is going to be using these specific functions, though. I think it would be better to keep those functions declared and just make them NULL in the struct, which avoids rearranging all the following functions.
Attachment #655390 - Flags: review?(benjamin) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 655641 [details] [diff] [review]
remove them

Thanks, that makes sense.
Assignee: nobody → continuation
Attachment #655390 - Attachment is obsolete: true
Attachment #655641 - Flags: review?(benjamin)

Updated

5 years ago
Attachment #655641 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5dee7e43fa

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0a5dee7e43fa
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.