Closed Bug 785666 Opened 8 years ago Closed 8 years ago

[CC] Get rid of old-style Suspect and Forget

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

I suppose in theory this could cause problems for binary addons, but this code is totally untested, so any such users should switch over to Suspect2 and Forget2.
Blocks: CleanupCC
Attached patch WIP (obsolete) — Splinter Review
Comment on attachment 655390 [details] [diff] [review]
WIP

Ask review also from bsmedberg
Attachment #655390 - Flags: review?(bugs) → review+
Attachment #655390 - Flags: review?(benjamin)
Comment on attachment 655390 [details] [diff] [review]
WIP

So hrm, the only part of this that's maybe a problem is the XPCOMFunctions/kFrozenFunctions bit. Nobody is *supposed* to be using that struct across versions any more, but I bet they are. I'm pretty sure nobody is going to be using these specific functions, though. I think it would be better to keep those functions declared and just make them NULL in the struct, which avoids rearranging all the following functions.
Attachment #655390 - Flags: review?(benjamin) → review-
Attached patch remove themSplinter Review
Thanks, that makes sense.
Assignee: nobody → continuation
Attachment #655390 - Attachment is obsolete: true
Attachment #655641 - Flags: review?(benjamin)
Attachment #655641 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/0a5dee7e43fa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.