785666 - [CC] Get rid of old-style Suspect and Forget

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight (out until 2026) [:mccr8]]

I suppose in theory this could cause problems for binary addons, but this code is totally untested, so any such users should switch over to Suspect2 and Forget2.

Comment 1

[Andrew McCreight (out until 2026) [:mccr8]]

Attachment: WIP

Comment 2

[Andrew McCreight (out until 2026) [:mccr8]]

Comment on attachment 655390 [details] [diff] [review]
WIP

Try run looked okay.

https://tbpl.mozilla.org/?tree=Try&rev=9dd920702889

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 655390 [details] [diff] [review]
WIP

Ask review also from bsmedberg

Comment 4

[Benjamin Smedberg]

Comment on attachment 655390 [details] [diff] [review]
WIP

So hrm, the only part of this that's maybe a problem is the XPCOMFunctions/kFrozenFunctions bit. Nobody is *supposed* to be using that struct across versions any more, but I bet they are. I'm pretty sure nobody is going to be using these specific functions, though. I think it would be better to keep those functions declared and just make them NULL in the struct, which avoids rearranging all the following functions.

Comment 5

[Andrew McCreight (out until 2026) [:mccr8]]

Attachment: remove them

Thanks, that makes sense.

Comment 6

[Andrew McCreight (out until 2026) [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5dee7e43fa

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0a5dee7e43fa