Editor should open text/css, text/javascript, application/x-javascript files

VERIFIED FIXED

Status

()

Core
Editor
--
enhancement
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: bz, Assigned: Simon Fraser)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

spun off of bug 77080.

When opening CSS/JS files in editor, we get the "Can't edit this type of file"
alert and then the window closes.  Perhaps we should just open them the way we
would text/plain?
Once bug 77080 is fixed, this becomes a very small and simple patch.  Adding
dependency and will attach the patch in question.
Depends on: 77080
Created attachment 32943 [details] [diff] [review]
patch to fix this
Keywords: mozilla0.9.1, patch, review

Comment 3

17 years ago
with Simon cc'ed on this one, I am reassigning to Boris, since he has the patch 
for this already
Assignee: beppe → bzbarsky

Comment 4

17 years ago
I haven't tested this patch so I could be wrong.  I'm concerned that other parts 
of the editor won't handle these types of files correctly.  How much testing has 
been done with this?  Does "save" work correctly?
(Assignee)

Comment 5

17 years ago
Saving of text files is already broken: bug 47640.
Adding dependency on bug 47640 since until that's fixed this one is impossible
to test...
Depends on: 47640
I should note that barring bug 47640 "save" does work correctly.  I'll test this
some more once 47640 is fixed.
(Assignee)

Comment 8

17 years ago
Fixes checked in.
Assignee: bzbarsky → sfraser
(Assignee)

Comment 9

17 years ago
I fixed this; it needed more than the patch in this bug (to handle RDF and XUL, 
at least). But thanks for the patch!
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 10

17 years ago
Boris, is this working for you now?
Oops.  I thought I'd verified this one.  :)  verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.