78568 - Editor should open text/css, text/javascript, application/x-javascript files

Status: VERIFIED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

spun off of bug 77080.

When opening CSS/JS files in editor, we get the "Can't edit this type of file"
alert and then the window closes.  Perhaps we should just open them the way we
would text/plain?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Once bug 77080 is fixed, this becomes a very small and simple patch.  Adding
dependency and will attach the patch in question.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: patch to fix this

Comment 3

[rubydoo123]

with Simon cc'ed on this one, I am reassigning to Boris, since he has the patch 
for this already

Comment 4

[Kathleen :Brade]

I haven't tested this patch so I could be wrong.  I'm concerned that other parts 
of the editor won't handle these types of files correctly.  How much testing has 
been done with this?  Does "save" work correctly?

Comment 5

[Simon Fraser [no longer active]]

Saving of text files is already broken: bug 47640.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Adding dependency on bug 47640 since until that's fixed this one is impossible
to test...

Comment 7

[Boris Zbarsky [:bzbarsky]]

I should note that barring bug 47640 "save" does work correctly.  I'll test this
some more once 47640 is fixed.

Comment 8

[Simon Fraser [no longer active]]

Fixes checked in.

Comment 9

[Simon Fraser [no longer active]]

I fixed this; it needed more than the patch in this bug (to handle RDF and XUL, 
at least). But thanks for the patch!

Comment 10

[sujay]

Boris, is this working for you now?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Oops.  I thought I'd verified this one.  :)  verified.