Closed Bug 785745 Opened 12 years ago Closed 12 years ago

Stop using DOMAttrModified events

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Proposed patch
5.53 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review 
Instead we should use the new HTML5 mutation observers.
Attached patch Proposed patch — — Splinter Review 
HTML5 mutation observers conveniently simplify the code because they can be configured to only listen to a change on a specific attribute and element.

In theory I can store the mutation options in a variable too but I didn't think it was worth it when there are only two uses of it.

I also removed a variable that I noticed was left over by bug 605786...
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #655455 - Flags: review?(iann_bugzilla)
Attachment #655455 - Flags: review?(iann_bugzilla) → review+
Version: unspecified → Trunk
Pushed comm-central changeset a70b1d620a03.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: