785758 - Lock animation might get jumpy when using back/forward buttons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Attachment: Always update security and reader modes after progress visibility

This happens when you go from a website with lock icon to one without then pressing back to return. The animation might become jumpy because UI updates for the toolbar are happening out of order.

Comment 1

[Lucas Rocha (:lucasr)]

Comment on attachment 655464 [details] [diff] [review]
Always update security and reader modes after progress visibility

[Approval Request Comment]
User impact if declined: Ugly jumpy animation of lock icon and title when you use back/forward.
Testing completed (on m-c, etc.): extensive local testing, works great.
Risk to taking this patch (and alternatives if risky): Very low, it simply sorts the updates on browser toolbar with a saner order.
String or UUID changes made by this patch: None.

Comment 2

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9c6cebe4aa59

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

After thinking about this a bit more, I see how this change is still kinda weak. Someone will, at some point, flip these around again... accidentally of course.

If these is some fixed flow required, we should have an API, or methods, designed to enforce the flow. File a followup to look more carefully at this issue?

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9c6cebe4aa59

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> After thinking about this a bit more, I see how this change is still kinda
> weak. Someone will, at some point, flip these around again... accidentally
> of course.
> 
> If these is some fixed flow required, we should have an API, or methods,
> designed to enforce the flow. File a followup to look more carefully at this
> issue?

Good point, filed bug 785825 to track this.

Comment 6

[Andreea Pod]

All works fine and smooth when going back and forward from a site with lock icon to one without lock icon. 

Build: Firefox 17.0a1 (2012-08-27)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Comment 7

[Lucas Rocha (:lucasr)]

Pushed to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/b88ab611becb

Comment 8

[Cristian Nicolae (:xti)]

Lock animation is smooth on the latest Beta build. Setting the firefox 16 flag as verified.

--
Firefox 16.0b5 (2012-09-26)
Device: Galaxy Note
OS: Android 4.0.4