Closed Bug 785815 Opened 8 years ago Closed 8 years ago

[Tracking Bug] Set up tooltool for SeaMonkey

Categories

(SeaMonkey :: Release Engineering, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(3 files, 4 obsolete files)

Tooltool needs to be set up in order to use clang to build on the OSX64
machines.  

This bug is to track the progress of the tooltool setup.
Blocks: 775539
Attachment #655544 - Flags: review?(bugspam.Callek)
Attachment #655545 - Flags: review?(bugspam.Callek)
Attachment #655546 - Flags: review?(bugspam.Callek)
Comment on attachment 655544 [details] [diff] [review]
Tools/scripts required for tooltool.  (WIP)

/scripts/tooltool/fetch_and_unpack.sh is fine, but we don't want 
/tooltool.py here

tooltool.py gets manually deployed to the slaves in /tools/* (which is not an hg repo there) See the manifests in puppet http://mxr.mozilla.org/build/source/puppet/modules/packages/manifests/mozilla/tooltool.pp#1 and http://mxr.mozilla.org/build/source/puppet-manifests/modules/packages/manifests/tooltool.pp#1

That can/should be easy though
Attachment #655544 - Flags: review?(bugspam.Callek)
Attachment #655544 - Flags: review-
Attachment #655544 - Flags: feedback+
Comment on attachment 655545 [details] [diff] [review]
Buildbotcustom changes for tooltool usage. (WIP)

Review of attachment 655545 [details] [diff] [review]:
-----------------------------------------------------------------

The changes in misc.py look good where they are, but they are ALSO needed in the function |generateCCBranchObjects| in almost identical places.

The factory.py changes look good, but r- because without the misc.py changes we won't see any benefit.
Attachment #655545 - Flags: review?(bugspam.Callek) → review-
Comment on attachment 655546 [details] [diff] [review]
Buildbot configs for tooltool setup for SeaMonkey. (WIP)

All that is in this patch looks good, but we also need to specify the tooltool_url_list in our GLOBAL_VARS above, see e.g. http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/production_config.py#82

But we need to use http://tooltool.pub.build.mozilla.org/temp-sm-stuff/ as our url.
Attachment #655546 - Flags: review?(bugspam.Callek)
Attachment #655546 - Flags: review-
Attachment #655546 - Flags: feedback+
Attachment #655545 - Attachment is obsolete: true
Attachment #657657 - Flags: review?(bugspam.Callek)
Attachment #655546 - Attachment is obsolete: true
Attachment #655544 - Attachment is obsolete: true
Attachment #657673 - Flags: review?(bugspam.Callek)
Attachment #657672 - Flags: review+
Comment on attachment 657657 [details] [diff] [review]
Buildbotcustom changes to enable tooltool for SeaMonkey (v2)

Review of attachment 657657 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with my nits

::: misc.py
@@ +2682,5 @@
>                          baseMirrorUrls=config.get('base_mirror_urls'),
>                          extraConfigureArgs=config.get('l10n_extra_configure_args', []),
>                          branchName=name,
> +                        'tooltool_manifest_src': pf.get('tooltool_manifest_src', None),
> +                        'tooltool_url_list': config.get('tooltool_url_list', []),

Remove these ones, we don't do tooltool in the Repack factory for m-c either.

@@ +2809,5 @@
>                  baseMirrorUrls=config.get('base_mirror_urls'),
>                  extraConfigureArgs=config.get('l10n_extra_configure_args', []),
>                  branchName=name,
> +                'tooltool_manifest_src': pf.get('tooltool_manifest_src', None),
> +                'tooltool_url_list': config.get('tooltool_url_list', []),

Same here
Attachment #657657 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 657673 [details] [diff] [review]
Tools/scripts required for tooltool. (v2)

Review of attachment 657673 [details] [diff] [review]:
-----------------------------------------------------------------

Just to be extra clear, this lands to hg.m.o/users/Callek_gmail.com/tools
Attachment #657673 - Flags: review?(bugspam.Callek) → review+
Attachment #657657 - Attachment is obsolete: true
Attachment #657750 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.