785815 - [Tracking Bug] Set up tooltool for SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

Tooltool needs to be set up in order to use clang to build on the OSX64
machines.  

This bug is to track the progress of the tooltool setup.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Tools/scripts required for tooltool. (WIP)

Comment 2

[Edmund Wong (:ewong)]

Attachment: Buildbotcustom changes for tooltool usage. (WIP)

Comment 3

[Edmund Wong (:ewong)]

Attachment: Buildbot configs for tooltool setup for SeaMonkey. (WIP)

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 655544 [details] [diff] [review]
Tools/scripts required for tooltool.  (WIP)

/scripts/tooltool/fetch_and_unpack.sh is fine, but we don't want 
/tooltool.py here

tooltool.py gets manually deployed to the slaves in /tools/* (which is not an hg repo there) See the manifests in puppet http://mxr.mozilla.org/build/source/puppet/modules/packages/manifests/mozilla/tooltool.pp#1 and http://mxr.mozilla.org/build/source/puppet-manifests/modules/packages/manifests/tooltool.pp#1

That can/should be easy though

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 655545 [details] [diff] [review]
Buildbotcustom changes for tooltool usage. (WIP)

Review of attachment 655545 [details] [diff] [review]:
-----------------------------------------------------------------

The changes in misc.py look good where they are, but they are ALSO needed in the function |generateCCBranchObjects| in almost identical places.

The factory.py changes look good, but r- because without the misc.py changes we won't see any benefit.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 655546 [details] [diff] [review]
Buildbot configs for tooltool setup for SeaMonkey. (WIP)

All that is in this patch looks good, but we also need to specify the tooltool_url_list in our GLOBAL_VARS above, see e.g. http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/production_config.py#82

But we need to use http://tooltool.pub.build.mozilla.org/temp-sm-stuff/ as our url.

Comment 7

[Edmund Wong (:ewong)]

Attachment: Buildbotcustom changes to enable tooltool for SeaMonkey (v2)

Comment 8

[Edmund Wong (:ewong)]

Attachment: Buildbot configs for setting up tooltool. (v2)

Comment 9

[Edmund Wong (:ewong)]

Attachment: Tools/scripts required for tooltool. (v2)

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 657657 [details] [diff] [review]
Buildbotcustom changes to enable tooltool for SeaMonkey (v2)

Review of attachment 657657 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with my nits

::: misc.py
@@ +2682,5 @@
>                          baseMirrorUrls=config.get('base_mirror_urls'),
>                          extraConfigureArgs=config.get('l10n_extra_configure_args', []),
>                          branchName=name,
> +                        'tooltool_manifest_src': pf.get('tooltool_manifest_src', None),
> +                        'tooltool_url_list': config.get('tooltool_url_list', []),

Remove these ones, we don't do tooltool in the Repack factory for m-c either.

@@ +2809,5 @@
>                  baseMirrorUrls=config.get('base_mirror_urls'),
>                  extraConfigureArgs=config.get('l10n_extra_configure_args', []),
>                  branchName=name,
> +                'tooltool_manifest_src': pf.get('tooltool_manifest_src', None),
> +                'tooltool_url_list': config.get('tooltool_url_list', []),

Same here

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 657673 [details] [diff] [review]
Tools/scripts required for tooltool. (v2)

Review of attachment 657673 [details] [diff] [review]:
-----------------------------------------------------------------

Just to be extra clear, this lands to hg.m.o/users/Callek_gmail.com/tools

Comment 12

[Edmund Wong (:ewong)]

Attachment: Buildbotcustom changes to enable tooltool for SeaMonkey (v3)

Comment 13

[Edmund Wong (:ewong)]

Pushed to buildbotcustom: 
http://hg.mozilla.org/build/buildbotcustom/rev/399f2d5410f3

Pushed to buildbot-configs:
http://hg.mozilla.org/build/buildbot-configs/rev/bc929994cf4b

Pushed to Callek's tools:
http://hg.mozilla.org/users/Callek_gmail.com/tools/rev/846be07053cb

Comment 14

[Edmund Wong (:ewong)]

Pushed fixes to buildbotcustom:
http://hg.mozilla.org/build/buildbotcustom/rev/08f81c38d65b
http://hg.mozilla.org/build/buildbotcustom/rev/f39399b891cd

Comment 15

[Justin Wood (:Callek)]

And a chmod fix to the tools script: http://hg.mozilla.org/users/Callek_gmail.com/tools/rev/779e6561250a

Comment 16

[Edmund Wong (:ewong)]

Pushed buildbot-configs fix:
http://hg.mozilla.org/build/buildbot-configs/rev/6798dac2ba17