Ensure that libxul.so is loaded lazily

RESOLVED FIXED in Firefox 17

Status

()

Toolkit
OS.File
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

unspecified
mozilla18
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 655551 [details] [diff] [review]
Load libxul.so lazily

Here we go.
Assignee: nobody → dteller
Attachment #655551 - Flags: review?(nfroyd)
Comment on attachment 655551 [details] [diff] [review]
Load libxul.so lazily

Review of attachment 655551 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC, we don't have to modify back-end specific things because they don't interact with libxul, correct?
Attachment #655551 - Flags: review?(nfroyd) → review+
Indeed, at the moment, nothing interacts with libxul besides the string-related functions patched here.
Created attachment 655957 [details] [diff] [review]
Load libxul.so lazily
Attachment #655551 - Attachment is obsolete: true
Attachment #655957 - Flags: review+
Keywords: checkin-needed
For reference, loading libxul.so eagerly causes all sorts of "interesting" errors during the construction of the startup cache. I tend to believe that this is actually a design error in the startup cache, but loading libxul.so lazily makes sense, in addition of postponing the time at which we will need to fix the startup cache construction.
https://tbpl.mozilla.org/?tree=Try&rev=ce0eb243566d
(In reply to Ryan VanderMeulen from comment #6)
> https://tbpl.mozilla.org/?tree=Try&rev=ce0eb243566d

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/04d13cf166ab
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/04d13cf166ab
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Created attachment 661829 [details] [diff] [review]
backport to aurora

Try run at https://tbpl.mozilla.org/?tree=Try&rev=099466ea69fc

Porting this patch to Aurora makes it safer to port the patch in bug 787334 and that one fixes "make package" for XULRunner.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: None
Testing completed (on m-c, etc.): Try is running. 
Risk to taking this patch (and alternatives if risky): Build problems. 
String or UUID changes made by this patch: None
Attachment #661829 - Flags: approval-mozilla-aurora?
Comment on attachment 661829 [details] [diff] [review]
backport to aurora

Looks like it will be obvious if this doesn't work on Aurora, approving.
Attachment #661829 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/4d10018bb0f0

Updated

5 years ago
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.