785828 - Ensure that libxul.so is loaded lazily

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Load libxul.so lazily

Here we go.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 655551 [details] [diff] [review]
Load libxul.so lazily

Review of attachment 655551 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC, we don't have to modify back-end specific things because they don't interact with libxul, correct?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Indeed, at the moment, nothing interacts with libxul besides the string-related functions patched here.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Load libxul.so lazily

Comment 5

[David Teller [:Yoric] - still alive but not very active]

For reference, loading libxul.so eagerly causes all sorts of "interesting" errors during the construction of the startup cache. I tend to believe that this is actually a design error in the startup cache, but loading libxul.so lazily makes sense, in addition of postponing the time at which we will need to fix the startup cache construction.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=ce0eb243566d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen from comment #6)
> https://tbpl.mozilla.org/?tree=Try&rev=ce0eb243566d

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/04d13cf166ab

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04d13cf166ab

Comment 9

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: backport to aurora

Try run at https://tbpl.mozilla.org/?tree=Try&rev=099466ea69fc

Porting this patch to Aurora makes it safer to port the patch in bug 787334 and that one fixes "make package" for XULRunner.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: None
Testing completed (on m-c, etc.): Try is running. 
Risk to taking this patch (and alternatives if risky): Build problems. 
String or UUID changes made by this patch: None

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 661829 [details] [diff] [review]
backport to aurora

Looks like it will be obvious if this doesn't work on Aurora, approving.

Comment 11

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d10018bb0f0