785850 - Add rate limiting to number of support forum helpful votes per day

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Kadir Topal [:atopal]]

Please add rate limiting to the number of support forum helpful votes that visitors can use per day.

* Let the limit be 10 per day for starters.
* After the 10th vote, just stop counting any additional votes

* For anonymous visitors use the IP to identify them.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

A lot to figure out here. => 3pt

Comment 2

[Alice Wyman]

Related discussion:

https://support.mozilla.org/forums/contributors/708886

Comment 3

[Michael Cooper [:mythmon]]

I'm going to take a stab at this tomorrow.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

wrong field, oops

Comment 5

[James Socol [:jsocol, :james]]

If this slips (it probably will) it's my fault. It depended on an upstream change in django-ratelimit and between the travel and conferences last week, I didn't get to it in time.

I'm working on this right now, though, so I'm need-info?ing myself, and I'll clear that out as soon as I'm done.

Comment 6

[Michael Cooper [:mythmon]]

I sketched out how this would look in SUMO, assuming some things about how django-ratelimit works. It was pretty simple, and just requires some careful testing when doing things manually. Most of the rest of the work is writing some tests for this and verifying that it works as expected.

In other words, once James' changes to django-ratelimit happen, this should be pretty quick. James is doing the heavy lifting here, so once that is done the SUMO part should be easy.

Comment 7

[James Socol [:jsocol, :james]]

Pushed ratelimit v0.3.0 to PyPI. This isn't exactly Mike's patch but it should get the job done.

Comment 8

[Michael Cooper [:mythmon]]

PR: https://github.com/mozilla/kitsune/pull/1217

Comment 9

[Michael Cooper [:mythmon]]

Landed in: https://github.com/mozilla/kitsune/65b9a5bfce11c9a35b7d3b66c7b057e9ae5c6783
Deployed to master just now.

Tested that one person hitting the limit on stage doesn't hurt others, and that IP and user are limited separately.