Closed
Bug 785851
Opened 13 years ago
Closed 13 years ago
Add rate limiting to number of support forum answers per minute
Categories
(support.mozilla.org :: Questions, task, P3)
support.mozilla.org
Questions
Tracking
(Not tracked)
RESOLVED
FIXED
2013Q2
People
(Reporter: atopal, Assigned: rrosario)
References
Details
(Whiteboard: u=contributor c=questions p=2 s=2013.7)
Please add rate limiting to the number of support forum answers that user can submit per minute and day.
* Let the limit be 1 per minute, and 50 per day
* After those limits show a captcha
| Reporter | ||
Updated•13 years ago
|
Target Milestone: --- → 2012.18
| Assignee | ||
Comment 1•13 years ago
|
||
Cor-el answers more than 50 per day, I think?
| Assignee | ||
Updated•13 years ago
|
Component: Knowledge Base Software → Questions
QA Contact: kb-software
Comment 2•13 years ago
|
||
Definitely. I'd say at least 150-200 individual replies a day. Ed (the-edmeister) also needs to be accounted for as well.
And I'm strongly against any type of captchas being used. I've always hated them. Even when had them before the 2010 redesign. Can we instead implement a timeout? Something like: You've exceeded the post limit for [the moment/the day]. Wait 2 minutes and try again.
I also think these limits should vary by group. Strictest limits for newly registered contributors (1 post per min/3 threads per day). Or perhaps no limits for anyone in the moderator group. But if we have a veteran or trusted contributor that has a high posting rate but is not apart of the mod group, we could make a Trusted group (that also has no rate limits) and add those users to it.
| Reporter | ||
Comment 3•13 years ago
|
||
Noah, part of this is excluding active contributors. This is only to catch spammers. Cor-el and others would not be affected at all.
| Assignee | ||
Comment 4•13 years ago
|
||
Putting into next sprint. Based on the rate-limiting work :mythmon already did, I *think* this should be a 1pter. :mythmon - correct that if I am wrong.
Priority: -- → P3
Whiteboard: u=contributor c=questions p= → u=contributor c=questions p=1 s=2013.7
Target Milestone: 2012.18 → 2013Q2
Comment 5•13 years ago
|
||
There is one thing that is concerning here: the rate limit is currently global. There isn't a way to make this ratelimit and the ratelimit of the helpful votes we made earlier separate (yet). So this will probably require changes to either a) Our key functions, or b) django-ratelimit.
Given that, probably 2 points.
Whiteboard: u=contributor c=questions p=1 s=2013.7 → u=contributor c=questions p=2 s=2013.7
| Assignee | ||
Comment 6•13 years ago
|
||
I'm done with me bugs and grabbing this before anybody else!
Assignee: nobody → rrosario
| Assignee | ||
Comment 7•13 years ago
|
||
(In reply to Kadir Topal [:atopal] from comment #0)
> * Let the limit be 1 per minute, and 50 per day
Our rate-limiting infrastructure can only do one of these right now AFAIK. So I am going to go with 1/minute. This way it doesnt affect the power users that do over 50 a day.
| Assignee | ||
Comment 8•13 years ago
|
||
I'm guessing this one is going to affect our tests. Hoping not!
| Assignee | ||
Comment 9•13 years ago
|
||
In a pull request:
https://github.com/mozilla/kitsune/pull/1269
| Assignee | ||
Comment 10•13 years ago
|
||
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #8)
> I'm guessing this one is going to affect our tests. Hoping not!
It didn't affect our tests since we usually go through the model makers and not the test client to create answers. But it might affect selenium tests!
| Assignee | ||
Comment 11•13 years ago
|
||
| Assignee | ||
Comment 12•13 years ago
|
||
Deployed to prod now.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 13•13 years ago
|
||
BTW, we didn't do captcha. We just show a warning to wait for a little.
Comment 14•13 years ago
|
||
Related contributors discussion thread, posted today by cor-el:
https://support.mozilla.org/en-US/forums/contributors/709149 What about this? You have exceeded the number of answers that can be posted in a minute. Please try again shortly.
Comment 15•13 years ago
|
||
I do a lot of pasting and easily hit this limit.
We need to be able to do at least three or four replies per minute.
Are edits excluded as well (my own and editing other posts)?
| Assignee | ||
Comment 16•13 years ago
|
||
(In reply to Cor vL (cor-el) from comment #15)
> I do a lot of pasting and easily hit this limit.
>
> We need to be able to do at least three or four replies per minute.
>
> Are edits excluded as well (my own and editing other posts)?
See Bug 862347
You need to log in
before you can comment on or make changes to this bug.
Description
•