785885 - Adjust/tweak text positioning in landscape layout in about:feedback

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (08/27) - Screenshot

See screenshot.

--
Nightly (08/27), Galaxy Nexus (Android 4.1.1)

Comment 1

[:Margaret Leibovic]

Oof, good catch.

Comment 2

[:Margaret Leibovic]

Attachment: patch

The problem was caused by the fact that we use position: absolute; on these bottom-aligned divs. To fix that, I used media queries to just add some top margin instead if the screen height is less than 400px. I also took this opportunity to get rid of the top padding on the body when the screen height is too small, to avoid needing to scroll the page.

I just picked 400px because that seems to do the job. Is there something smarter I should be doing? I considered doing portrait/landscape, but I didn't want to affect tablets.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 655712 [details] [diff] [review]
patch

Margaret answered my nags on IRC. Please try using "device-height" and see if VKB still affects the layout. If not, use it. If so, stick with "max-height".

Comment 4

[:Margaret Leibovic]

I tried using device-height, but I couldn't find a pixel value that worked on both my Galaxy Nexus and my Nexus S, perhaps because the menu buttons on the Galaxy Nexus were being included in the device height value (this is just a guess). Anyway, basing the calculation on the size of the content seems to make the most sense, so I just stuck with that. If we find that this has bad interactions with the VKB, we can file a follow-up, but I was already seeing a redraw flash when the VKB came up before this creating this patch, so it seems there are different problems there.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1a0b963ffb1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c1a0b963ffb1

Comment 6

[:Margaret Leibovic]

Comment on attachment 655712 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): feedback solicitation (bug 774479)
User impact if declined: styling is bad in landscape mode
Testing completed (on m-c, etc.): landed on m-c 8/28
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: n/a

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8b505ea0a7b7

Comment 8

[:Margaret Leibovic]

Comment on attachment 655712 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): feedback solicitation (bug 774479)
User impact if declined: styling is bad in landscape mode
Testing completed (on m-c, etc.): landed on m-c 8/28
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: n/a

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 655712 [details] [diff] [review]
patch

[Triage Comment]
We've just approved the feedback solicitation bug for Beta - let's land this at the same time.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-beta/rev/8801895bc9b5

Comment 11

[Andreea Pod]

Verified fixed.

Build: Firefox 18.0a1 (2012-09-04), Firefox 17.0a2 (2012-09-04)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Comment 12

[Adrian Tamas (:AdrianT)]

Text is displayed in the correct position on the latest Beta build.

Firefox Mobile 16.0b5
Device: Samsung Galaxy Nexus
OS: Android 4.1.1