Closed Bug 785898 Opened 12 years ago Closed 10 years ago

Reapply search controls to filter by device

Categories

(Marketplace Graveyard :: Search, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: kumar, Unassigned)

References

Details

(Whiteboard: [u=dev c=mkt-search p=1])

After the gaia merge, tests to verify searching and filtering by device type broke. Example:
https://ci.mozilla.org/job/marketplace-es/86/testReport/junit/workspace.mkt.search.tests.test_views/TestWebappSearch/test_device_all/

If this feature is still needed, it should be fixed. Otherwise, the tests should be deleted.
for now I'm skipping these tests in a branch. Let me know if I can delete them.
CCing Maria - Will these features be making a come back any time soon?
Depending on the decision, this is the test method to delete/unskip https://github.com/mozilla/zamboni/commit/c816d795e3e6250008a7a4506f7a9cfa93e3e978 (note that several tests call that helper)
(In reply to Wil Clouser [:clouserw] from comment #2)
> CCing Maria - Will these features be making a come back any time soon?

Right now, it's impossible to know which apps are device compliant, which I'm sure will cause a lot of user frustration when users download mobile-only or tablet-only apps for desktop.
(In reply to Chris Van Wiemeersch [:cvan] from comment #4)
> (In reply to Wil Clouser [:clouserw] from comment #2)
> > CCing Maria - Will these features be making a come back any time soon?
> 
> Right now, it's impossible to know which apps are device compliant, which
> I'm sure will cause a lot of user frustration when users download
> mobile-only or tablet-only apps for desktop.

Until we offer the possibility to download and run apps for desktop this shouldn't be a problem?
(In reply to Maria Sandberg [:mushi] from comment #5)
> (In reply to Chris Van Wiemeersch [:cvan] from comment #4)
> > (In reply to Wil Clouser [:clouserw] from comment #2)
> > > CCing Maria - Will these features be making a come back any time soon?
> > 
> > Right now, it's impossible to know which apps are device compliant, which
> > I'm sure will cause a lot of user frustration when users download
> > mobile-only or tablet-only apps for desktop.
> 
> Until we offer the possibility to download and run apps for desktop this
> shouldn't be a problem?

The current plan as I know it is to still allow installation of apps on desktop.
Installation of apps on desktop is a P2 priority for Q4.  It will become more important next year, it is definitely happening at some point in the future.
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [u=dev c=mkt-search p=]
Delete the tests and close the bug.  This is changing with Fireplace and Send to Phone and the way we interact with discovery is going to be different.  No need to keep this around.
Whiteboard: [u=dev c=mkt-search p=] → [u=dev c=mkt-search p=1]
Priority: -- → P4
Closing based on comment 8 and this was removed in commit:
https://github.com/mozilla/zamboni/commit/4b03216e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.