Last Comment Bug 785903 - Markup panel selection should scroll to the center when highlighting
: Markup panel selection should scroll to the center when highlighting
Status: RESOLVED FIXED
[good-first-bug][mentor=dcamp][lang=js]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: 13 Branch
: All All
: -- normal (vote)
: Firefox 18
Assigned To: Jan Skrasek
:
: Patrick Brosset <:pbro>
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-27 08:50 PDT by Dave Camp (:dcamp)
Modified: 2012-10-02 03:07 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch 01 (2.02 KB, patch)
2012-09-01 11:16 PDT, Jan Skrasek
dcamp: review+
Details | Diff | Splinter Review

Description Dave Camp (:dcamp) 2012-08-27 08:50:43 PDT
The markup panel currently uses LayoutHelpers.ScrollIntoViewIfNeeded() with center=false to make sure the selection is visible.  This feels right when paging through the list with keynav, but when we get an external select from the highlighter, we should probably use center=true.
Comment 1 Dave Camp (:dcamp) 2012-08-27 08:52:27 PDT
The markup view source is in browser/devtools/markupview/MarkupView.jsm - centering is done in showNode().  It's probably easiest to add a center arg to that method, and pass true from onSelect() and false from navigate().
Comment 2 SADINENI RAVI CHANDRA 2012-08-28 11:42:24 PDT
i would like to work on this bug... can you please assign this bug to me...
Comment 3 SADINENI RAVI CHANDRA 2012-08-28 11:42:49 PDT
and also can u explain what has to be done ...
Comment 4 Amod [:AMoz] 2012-08-31 09:45:45 PDT
Sir, I would like to contribute to this bug. If this bug is not already assigned I would be highly obliged if u assign the bug to me...Will u explain the bug in detail ?
Comment 5 Jan Skrasek 2012-09-01 11:15:42 PDT
Hi, I'd like also work on this issue. I have already downloaded mozilla-central & compiled a tested my code change. See attachment. Please, I have no idea how to make tests for this issue.
Comment 6 Jan Skrasek 2012-09-01 11:16:56 PDT
Created attachment 657585 [details] [diff] [review]
Patch 01
Comment 7 Dave Camp (:dcamp) 2012-09-28 08:36:26 PDT
Looks good, thanks!
Comment 8 Victor Porof [:vporof][:vp] 2012-10-01 09:37:27 PDT
https://hg.mozilla.org/integration/fx-team/rev/1ef6d7852465
Comment 9 Tim Taubert [:ttaubert] 2012-10-02 01:02:00 PDT
https://hg.mozilla.org/mozilla-central/rev/1ef6d7852465

Note You need to log in before you can comment on or make changes to this bug.