Closed Bug 785903 Opened 8 years ago Closed 8 years ago

Markup panel selection should scroll to the center when highlighting

Categories

(DevTools :: Inspector, defect)

13 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: dcamp, Assigned: jan)

Details

(Whiteboard: [good-first-bug][mentor=dcamp][lang=js])

Attachments

(1 file)

The markup panel currently uses LayoutHelpers.ScrollIntoViewIfNeeded() with center=false to make sure the selection is visible.  This feels right when paging through the list with keynav, but when we get an external select from the highlighter, we should probably use center=true.
The markup view source is in browser/devtools/markupview/MarkupView.jsm - centering is done in showNode().  It's probably easiest to add a center arg to that method, and pass true from onSelect() and false from navigate().
i would like to work on this bug... can you please assign this bug to me...
and also can u explain what has to be done ...
Sir, I would like to contribute to this bug. If this bug is not already assigned I would be highly obliged if u assign the bug to me...Will u explain the bug in detail ?
Hi, I'd like also work on this issue. I have already downloaded mozilla-central & compiled a tested my code change. See attachment. Please, I have no idea how to make tests for this issue.
Attached patch Patch 01Splinter Review
Attachment #657585 - Flags: feedback?(dcamp)
Attachment #657585 - Attachment is patch: true
Attachment #657585 - Flags: feedback?(dcamp) → review+
Looks good, thanks!
Whiteboard: [good-first-bug][mentor=dcamp][lang=js] → [good-first-bug][mentor=dcamp][lang=js][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/1ef6d7852465
Whiteboard: [good-first-bug][mentor=dcamp][lang=js][land-in-fx-team] → [good-first-bug][mentor=dcamp][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1ef6d7852465
Assignee: nobody → hrach.cz
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=dcamp][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=dcamp][lang=js]
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.