Closed
Bug 785903
Opened 13 years ago
Closed 13 years ago
Markup panel selection should scroll to the center when highlighting
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: dcamp, Assigned: jan)
Details
(Whiteboard: [good-first-bug][mentor=dcamp][lang=js])
Attachments
(1 file)
|
2.02 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
The markup panel currently uses LayoutHelpers.ScrollIntoViewIfNeeded() with center=false to make sure the selection is visible. This feels right when paging through the list with keynav, but when we get an external select from the highlighter, we should probably use center=true.
|
Reporter | |
Comment 1•13 years ago
|
||
The markup view source is in browser/devtools/markupview/MarkupView.jsm - centering is done in showNode(). It's probably easiest to add a center arg to that method, and pass true from onSelect() and false from navigate().
|
||
Comment 2•13 years ago
|
||
i would like to work on this bug... can you please assign this bug to me...
|
|
||
Comment 3•13 years ago
|
||
and also can u explain what has to be done ...
|
||
Comment 4•13 years ago
|
||
Sir, I would like to contribute to this bug. If this bug is not already assigned I would be highly obliged if u assign the bug to me...Will u explain the bug in detail ?
|
Assignee | |
Comment 5•13 years ago
|
||
Hi, I'd like also work on this issue. I have already downloaded mozilla-central & compiled a tested my code change. See attachment. Please, I have no idea how to make tests for this issue.
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #657585 -
Flags: feedback?(dcamp)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #657585 -
Attachment is patch: true
|
|
Reporter | |
Updated•13 years ago
|
Attachment #657585 -
Flags: feedback?(dcamp) → review+
|
|
Reporter | |
Comment 7•13 years ago
|
||
Looks good, thanks!
Whiteboard: [good-first-bug][mentor=dcamp][lang=js] → [good-first-bug][mentor=dcamp][lang=js][land-in-fx-team]
|
||
Comment 8•13 years ago
|
||
Whiteboard: [good-first-bug][mentor=dcamp][lang=js][land-in-fx-team] → [good-first-bug][mentor=dcamp][lang=js][fixed-in-fx-team]
|
||
Comment 9•13 years ago
|
||
Assignee: nobody → hrach.cz
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=dcamp][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=dcamp][lang=js]
Target Milestone: --- → Firefox 18
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•