Markup panel selection should scroll to the center when highlighting

RESOLVED FIXED in Firefox 18

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dcamp, Assigned: Jan Skrasek)

Tracking

13 Branch
Firefox 18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug][mentor=dcamp][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The markup panel currently uses LayoutHelpers.ScrollIntoViewIfNeeded() with center=false to make sure the selection is visible.  This feels right when paging through the list with keynav, but when we get an external select from the highlighter, we should probably use center=true.
(Reporter)

Comment 1

5 years ago
The markup view source is in browser/devtools/markupview/MarkupView.jsm - centering is done in showNode().  It's probably easiest to add a center arg to that method, and pass true from onSelect() and false from navigate().
i would like to work on this bug... can you please assign this bug to me...
and also can u explain what has to be done ...

Comment 4

5 years ago
Sir, I would like to contribute to this bug. If this bug is not already assigned I would be highly obliged if u assign the bug to me...Will u explain the bug in detail ?
(Assignee)

Comment 5

5 years ago
Hi, I'd like also work on this issue. I have already downloaded mozilla-central & compiled a tested my code change. See attachment. Please, I have no idea how to make tests for this issue.
(Assignee)

Comment 6

5 years ago
Created attachment 657585 [details] [diff] [review]
Patch 01
Attachment #657585 - Flags: feedback?(dcamp)
(Assignee)

Updated

5 years ago
Attachment #657585 - Attachment is patch: true
(Reporter)

Updated

5 years ago
Attachment #657585 - Flags: feedback?(dcamp) → review+
(Reporter)

Comment 7

5 years ago
Looks good, thanks!
Whiteboard: [good-first-bug][mentor=dcamp][lang=js] → [good-first-bug][mentor=dcamp][lang=js][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/1ef6d7852465
Whiteboard: [good-first-bug][mentor=dcamp][lang=js][land-in-fx-team] → [good-first-bug][mentor=dcamp][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1ef6d7852465
Assignee: nobody → hrach.cz
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=dcamp][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=dcamp][lang=js]
Target Milestone: --- → Firefox 18
You need to log in before you can comment on or make changes to this bug.