785910 - [Developer Toolbar] Inspector button and Web Console buttons remain selected after opening a new tab

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0

1. Load any page in a Firefox tab.
2. Select the Inspect button in the developer toolbar.
3. Open a new tab.

Actual result: the inspector button is highlighted while the Inspector is not selected. 

In addition, the same happens with the Web Console if:
1. Select the Inspector button.
2. Select, deselect, select the web console button.
3. Open a new tab.

Comment 1

[Paul Rouget [:paul]]

I can't reproduce.

By "Select the Inspect button", you mean "click the inspect button"?

Do you use the menubar as well?

Comment 2

[Virgil Dicu [:virgil] [QA]]

(In reply to Paul Rouget [:paul] from comment #1)
> By "Select the Inspect button", you mean "click the inspect button"?
Yes.

Happens with/without menubar - verified with latest Nightly.

1. Load any page in a Firefox tab.
2. Click the Inspect button in the developer toolbar.
3. Open a new tab.

The Inspector button is selected in the new tab while Inspector mode isn't active (no 3d view/style buttons)

Comment 3

[Paul Rouget [:paul]]

I can reproduce with a clean profile.

I'll investigate.

Comment 4

[Paul Rouget [:paul]]

I can't reproduce the 2nd STR.

Comment 5

[Virgil Dicu [:virgil] [QA]]

I can constantly reproduce with the steps from comment 0:

1. Click the Inspector button in the developer toolbar.
2. Click the web console button from the developer toolbar.
3. Deselect the web console in the developer toolbar.
4. Click the web console button in the developer toolbar.
5. Open a new tab.

Both buttons: Inspector and Web Console are selected. None of the tools is open.

Comment 6

[Paul Rouget [:paul]]

Can you please try something:

Reproduce this bug. Then just click on a new window (Firefox window, or any window, like a terminal or you mail client). Does it fix the problem?

Do you think you could get me a regression window?

Thank you.

Comment 7

[Virgil Dicu [:virgil] [QA]]

(In reply to Paul Rouget [:paul] from comment #6)
> Can you please try something:
> 
> Reproduce this bug. Then just click on a new window (Firefox window, or any
> window, like a terminal or you mail client). Does it fix the problem?

Yes it does!

(In reply to Paul Rouget [:paul] from comment #6)
> Do you think you could get me a regression window?
Sure, seems it's the same regression as in bug 784289:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6d8456a77e57&tochange=3a05d298599e

Three dev tool bugs in that range. There are no tinderbox builds available for that date anymore, but I can build and find the culprit if that's needed.

Comment 8

[Paul Rouget [:paul]]

Thank you! This is very helpful.

Comment 9

[Paul Rouget [:paul]]

Is it osx only?

Comment 10

[Virgil Dicu [:virgil] [QA]]

(In reply to Paul Rouget [:paul] from comment #9)
> Is it osx only?
It occurs across platforms. Checked Windows, Mac, Ubuntu.

Bisecting leads me to:
changeset: 99862:01929e390ba5
parent: 99773:e1dcf7c892d1 
parent: 99861:7b3b0c5c9933 
user: Tim Taubert <[e-mail]> 
date: Thu Jul 19 16:38:20 2012 +0200 summary: merge m-c to fx-team

That's expected, as it contains dev tools patches merged to fx team, but while building on inbound with the last one (the linux backout:7b3b0c5c9933), I can't reproduce.

Comment 11

[Virgil Dicu [:virgil] [QA]]

Attachment: Screencast

Comment 12

[Paul Rouget [:paul]]

Attachment: v1

Comment 13

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=68247bc17811

Comment 14

[Paul Rouget [:paul]]

That should do it.

Virgil, I'll ask you to re-test this with these builds (once available):
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-68247bc17811

Comment 15

[Virgil Dicu [:virgil] [QA]]

(In reply to Paul Rouget [:paul] from comment #14)
> That should do it.
> 
> Virgil, I'll ask you to re-test this with these builds (once available):
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/prouget@mozilla.
> com-68247bc17811

Checked with Linux build. No problems now with remembering state across tabs/windows and Tools menu/Dev toolbar.

Works great and also fixes the issue in bug 784289.

Comment 17

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/83ba44d1231c

Comment 18

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/83ba44d1231c

Comment 19

[Paul Rouget [:paul]]

Comment on attachment 658017 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 765564
User impact if declined: Button checked when they should not be checked
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: no

Comment 20

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/18.0 Firefox/18.0

Verified on Nightly with Ubuntu, Windows 7 and Mac OS. 

Does it make sense to port this to beta as well? F16 is still affected.

Comment 21

[Paul Rouget [:paul]]

Comment on attachment 658017 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 765564
User impact if declined: Button checked when they should not be checked
Testing completed (on m-c, etc.): m-c, aurora
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: no

Comment 22

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8980c232a0b9

Comment 23

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a9641a74ccad

Comment 24

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0

Also verified on F16 beta and F17 Aurora