Profiler: Support column info

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
7 years ago
7 months ago

People

(Reporter: BenWa, Assigned: denispal)

Tracking

(Blocks: 1 bug)

unspecified
mozilla63
x86
macOS
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

7 years ago
Bug 568142 added column info support to the JS engine. It isn't hard now to add column info the profiling which will let us better support minified scripts.
(Reporter)

Comment 1

7 years ago
Posted patch WIP (obsolete) — Splinter Review
Alex gave me his WIP over IRC
Blocks: 761253
Attachment #655627 - Attachment is obsolete: true
Comment hidden (mozreview-request)
The second patch changes the format for JS function names from "functionName (fileName:lineNo)" to "functionName (fileName:lineNo:column)". We will need to update code in the devtools performance panel and in perf.html to be able to parse the new string format.
(Assignee)

Updated

8 months ago
Assignee: nobody → dpalmeiro
(Assignee)

Comment 5

7 months ago
Most of the changes in the patches are still relevant and work once the frontend is updated.  The only extra change I had to add was a new column property in the frameTable schema.
(Assignee)

Comment 6

7 months ago
Add support for column numbers when profiling JS stack frames and functions.  This will help debug minified scripts when inspecting performance profiles.  The column information will be emitted as a new column property that is part of the frameTable in the profile output, and will also be appended in the descriptive profiler string.
Comment on attachment 8998985 [details]
bug 785922: Emit column numbers for JS frames and functions in the gecko profiler

Markus Stange [:mstange] has approved the revision.
Attachment #8998985 - Flags: review+
Comment on attachment 8998985 [details]
bug 785922: Emit column numbers for JS frames and functions in the gecko profiler

Steve Fink [:sfink] [:s:] has approved the revision.
Attachment #8998985 - Flags: review+
(Assignee)

Updated

7 months ago
Attachment #8954574 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Attachment #8954576 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 9

7 months ago
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb09f2ec0d28
Emit column numbers for JS frames and functions in the gecko profiler r=sfink,mstange
Keywords: checkin-needed
(Assignee)

Comment 11

7 months ago
(In reply to Arthur Iakab [arthur_iakab] from comment #10)
> Backed out changeset bb09f2ec0d28 (bug 785922)for causing Android build
> bustages on profiler/core/platform.cpp CLOSED TREE
> 
> Backout revision:
> https://hg.mozilla.org/integration/autoland/rev/
> 51881a2e2f9e1407f91ac39609685894c51fe729
> 
> Failed push:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=bb09f2ec0d284f79b4a49df1db8b455c53430be4&filter-
> resultStatus=testfailed&filter-resultStatus=busted&filter-
> resultStatus=exception&filter-classifiedState=unclassified
> 
> Link to the failure log:
> https://treeherder.mozilla.org/logviewer.html#?job_id=194551962&repo=autoland

Fixed a reference that needed updating which was only taken in the android path.
Flags: needinfo?(dpalmeiro)
Keywords: checkin-needed

Comment 12

7 months ago
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef6a3b493405
Emit column numbers for JS frames and functions in the gecko profiler r=sfink,mstange
Keywords: checkin-needed

Comment 13

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ef6a3b493405
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.