785927 - js/src/vm/ObjectImpl-inl.h:214:1: warning: unused function 'IsValueInCompartment' [-Wunused-function]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregory Szorc [:gps]]

I pulled m-c for the first time in about a week this morning and got a new compiler warning:

js/src/vm/ObjectImpl-inl.h:214:1: warning: unused function 'IsValueInCompartment' [-Wunused-function]

I'm seeing it repeated a few dozen times (because the header is included many places, I assume).

I'm building with Clang SVN HEAD minus a week or two on OS X.

Comment 1

[Terrence Cole [:terrence]]

Looks like I forgot #ifdef DEBUG markers around it.  Thanks for filing.

Comment 2

[Terrence Cole [:terrence]]

Attachment: v0: trivial

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 655628 [details] [diff] [review]
v0: trivial

Review of attachment 655628 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a peer for the JS module, so I don't think I can give r+. It looks good to me though.

Comment 4

[Terrence Cole [:terrence]]

I consider it a build issue, not a JS issue as such, but whatever.

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 655628 [details] [diff] [review]
v0: trivial

r+ from bhackett on IRC with feedback from Waldo that I should make it inline instead of static, since inline implies static in C++.

Comment 6

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72bb1083fbab

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72bb1083fbab