Remove mContentRect from FrameMetrics

RESOLVED FIXED in mozilla24

Status

()

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: drs, Assigned: kats)

Tracking

Trunk
mozilla24
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

mContentRect on FrameMetrics seems pretty useless. Not only can it be calculated from mCSSContentRect, but it's also not always completely up to date. We should remove it.
Depends on: 784908
For the record, I also think that mContentRect is being calculated incorrectly in APZC. At [1], mContentRect is assigned a value that is the CSS page size /divided by/ the resolution. All the code that uses this, and the other bits at [2] that set this value all do CSS page size /multiplied by/ the resolution (or equivalent).

I'm building a patch to get rid of this less-than-useless variable as it caused me to waste most of my day.

[1] https://hg.mozilla.org/mozilla-central/file/58bf49390ed4/gfx/layers/ipc/AsyncPanZoomController.cpp#l835
[2] https://hg.mozilla.org/mozilla-central/file/58bf49390ed4/layout/base/nsDisplayList.cpp#l664
Assignee: nobody → bugmail.mozilla
Depends on: 879004
Fairly confident I updated all the calculations appropriately. Try push in progress at https://tbpl.mozilla.org/?tree=Try&rev=37616b14a0f5
Attachment #760598 - Flags: review?(ajones)
Attachment #760598 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/a1ebe92839fa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.