785942 - Make sure WebMobileConnection is only defined in B2G build

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

From Bug 784709, mozMobileConnection should be only enabled in B2G.
Desktop firefox should NOT see this property under navigator.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL

Hi, sicking and smaug,
In order to make mozMobileConnection only exist in b2g build, I need to separate mozMobileConnection from nsIDOMNavigatorNetwork.idl first, 
so this is the patch for IDL modification.

Can you help to review this for me ?

Thanks

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update Impl

Hi, smaug
This patch updates the implementation.

Thanks

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Update test cases to remove mozMobileConnection from global interface.

Hi, smaug
This patch updates the test.

Thanks

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 655861 [details] [diff] [review]
Part 1: Update IDL


>+[scriptable, uuid(d8672694-3334-4d0d-a4c3-38fa70c265d0)]
>+interface nsIDOMMozNavigatorMobileConnection : nsISupports

This interface should not have nsIDOM prefix but nsI prefix.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Olli Pettay [:smaug] (slower than usual reviews for few days) from comment #4)
> Comment on attachment 655861 [details] [diff] [review]
> Part 1: Update IDL
> 
> 
> >+[scriptable, uuid(d8672694-3334-4d0d-a4c3-38fa70c265d0)]
> >+interface nsIDOMMozNavigatorMobileConnection : nsISupports
> 
> This interface should not have nsIDOM prefix but nsI prefix.

Hi, smaug
Should I need to rename the filename nsIDOMNavigatorMobileConnection.idl to nsINavigatorMobileConnection.idl as well ?

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL v2

Address to smaug's comments,
also rename the filename as well.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL v2

Address to smaug's comments,
also rename the filename as well.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 656128 [details] [diff] [review]
Part 1: Update IDL v2

network problem, update the same problem twice.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update Impl v2

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try result:
https://tbpl.mozilla.org/?tree=Try&rev=831a1ef610fb

sicking, superreview ping

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07b339718a40
https://hg.mozilla.org/integration/mozilla-inbound/rev/d87b9221e5c4
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3c2a6507e3

sicking, smaug:
Great thanks to your quick reviews. \O/

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07b339718a40
https://hg.mozilla.org/mozilla-central/rev/d87b9221e5c4
https://hg.mozilla.org/mozilla-central/rev/3a3c2a6507e3