785976 - Some searches are not sorting by popularity

Status: VERIFIED FIXED

(Marketplace Graveyard :: Search, defect)

Description

[Kumar McMillan [:kumar]]

Due to either ES bitrot or the gaia merge, several tests are failing because the results are not supported by popularity (i.e. weekly downloads, descending).

Example: https://ci.mozilla.org/job/marketplace-es/88/testReport/junit/workspace.mkt.search.tests.test_views/TestWebappSearch/test_free_and_premium/

The expected apps are in the result set but they are in the wrong order.

Comment 1

[Kumar McMillan [:kumar]]

In comment #0 : s/not supported/not sorted/

You can unskip these tests when ready https://github.com/mozilla/zamboni/commit/38c7043a6015544f96ab8d9af2a738e42d2b2105

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Yeah this is because the new designs call for

Search:
- browse by Relevance
- browse by Rating

Browse:
- browse by Popularity
- browse by Rating

Comment 3

[Kumar McMillan [:kumar]]

if you know what tests to delete from those skips above please delete away

Comment 4

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/zamboni/commit/3d43e71

@kumar sorry I saw this too late. Yea it's probably a good idea I'll clean that up a bit.

Comment 5

[Kumar McMillan [:kumar]]

Can you also remove the skips in the tests and see if they pass? https://github.com/mozilla/zamboni/commit/38c7043a6015544f96ab8d9af2a738e42d2b2105 You'll need to set RUN_ES_TESTS=True to run them. If those tests aren't relevant anymore then we should delete them.

Comment 6

[Kumar McMillan [:kumar]]

feel free to make a new bug for that too if that's more helpful.

Comment 7

[Davor Spasovski [:spasovski]]

New bug opened: 789977

This core bug should be resolved now.

Comment 8

[Victor Carciu]

Fixed by new designs. We can sort only by Relevancy and Rating.