Paris bindings need to honor global defines when munging nsCSSPropList.h

RESOLVED FIXED in mozilla18

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla18
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This cset:
  https://hg.mozilla.org/mozilla-central/rev/c526d9dfb684
broke my local builds with flexbox enabled (I've set MOZ_FLEXBOX=1 in configure.in)

It broke them in the sense that they no longer see any flexbox properties in node.style.*.

The flexbox properties are guarded by #ifdef MOZ_FLEXBOX (which configure.in should define.)

It looks like we just need to pass the configure.in #defines to the CSS2Properties.webidl-generating process.
(Assignee)

Comment 1

6 years ago
Created attachment 655685 [details] [diff] [review]
fix: add $(DEFINES) $(ACDEFINES) after $(CPP)
Attachment #655685 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/1dbf147c049a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.