786020 - B2G RIL: get rid of NETWORK_STATE_SUSPENDED

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

3G modems are smart about suspending data connections when they're inactive. On some devices this is transparent, on some (e.g. the Otoro) it gets reported through DATACALL_ACTIVE_UP and DOWN or NETWORK_STATE_CONNECTED or SUSPENDED, respectively. We do not report this consistently to the MobileConnection WebAPI, though. We report NETWORK_STATE_CONNECTED as connected, but SUSPENDED as disconnected.

See also https://github.com/mozilla-b2g/gaia/issues/3898.

Comment 1

[Philipp von Weitershausen [:philikon]]

Talked to Shian-Yow about this. We don't care in Gecko whether a network interface is active or suspended. To Gecko both states should mean connected. And in the UI we currently don't care either. If at some point we start caring, we can have the RIL report this state through navigator.mozMobileConnection.data.state or something.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 3

[Marshall Culpepper [:marshall_law]]

Comment on attachment 655772 [details] [diff] [review]
v1

Review of attachment 655772 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me :)

::: dom/system/gonk/ril_worker.js
@@ -53,5 @@
>  
>  const DEFAULT_EMERGENCY_NUMBERS = ["112", "911"];
>  
>  let RILQUIRKS_CALLSTATE_EXTRA_UINT32 = libcutils.property_get("ro.moz.ril.callstate_extra_int");
> -let RILQUIRKS_DATACALLSTATE_DOWN_IS_UP = libcutils.property_get("ro.moz.ril.callstate_down_is_up");

Do we need to remove this property from any device configs?

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to Marshall Culpepper [:marshall_law] from comment #3)
> > -let RILQUIRKS_DATACALLSTATE_DOWN_IS_UP = libcutils.property_get("ro.moz.ril.callstate_down_is_up");
> 
> Do we need to remove this property from any device configs?

Don't *need* to, but should. :) I'll do that via GitHub PRs.

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc16f1c44039

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc16f1c44039