786048 - Rename a bunch of event functions from *JSEventListener to *EventHandler to more accurately reflect the spec's vocabulary

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Pretty straightforwards.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 655763 [details] [diff] [review]
Patch

Review of attachment 655763 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventListenerManager.cpp
@@ +1028,5 @@
>  nsresult
> +nsEventListenerManager::SetEventHandlerToJsval(nsIAtom *aEventName,
> +                                               JSContext *cx,
> +                                               JSObject* aScope,
> +                                               const jsval & v)

While you're touching these lines, can you move */& to the left?

::: content/events/src/nsEventListenerManager.h
@@ +100,5 @@
>     * mTarget later and compile lazily.
>     */
>    // XXXbz does that play correctly with nodes being adopted across
>    // documents?  Need to double-check the spec here.
> +  nsresult SetEventHandler(nsIAtom *aName,

Same here

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 655763 [details] [diff] [review]
Patch

Need to change nsJSEventListener in a different bug I guess.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/40600eeda2c8

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I intentionally didn't rename nsJSEventListener because it is the listener for the handler.  The spec makes this distinction pretty clear.