Closed Bug 786048 Opened 7 years ago Closed 7 years ago

Rename a bunch of event functions from *JSEventListener to *EventHandler to more accurately reflect the spec's vocabulary

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: khuey, Assigned: khuey)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Pretty straightforwards.
Attachment #655763 - Flags: review?(bugs)
Comment on attachment 655763 [details] [diff] [review]
Patch

Review of attachment 655763 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventListenerManager.cpp
@@ +1028,5 @@
>  nsresult
> +nsEventListenerManager::SetEventHandlerToJsval(nsIAtom *aEventName,
> +                                               JSContext *cx,
> +                                               JSObject* aScope,
> +                                               const jsval & v)

While you're touching these lines, can you move */& to the left?

::: content/events/src/nsEventListenerManager.h
@@ +100,5 @@
>     * mTarget later and compile lazily.
>     */
>    // XXXbz does that play correctly with nodes being adopted across
>    // documents?  Need to double-check the spec here.
> +  nsresult SetEventHandler(nsIAtom *aName,

Same here
Comment on attachment 655763 [details] [diff] [review]
Patch

Need to change nsJSEventListener in a different bug I guess.
Attachment #655763 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/40600eeda2c8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
I intentionally didn't rename nsJSEventListener because it is the listener for the handler.  The spec makes this distinction pretty clear.
You need to log in before you can comment on or make changes to this bug.