Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: espindola, Unassigned)

Tracking

unspecified
mozilla18
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch s/IPC/ipc/Splinter Review
Believe it or not this is not a nop: on OS X with a case insensitive filesystem (the default) this reduces the symbol table size by one.

The problem is that when processing

#include "IPC/IPCMessageUtils.h

we end up in

#include "ShadowLayers.h"

which in the final XUL translates into the symbol (run nm -a to see it):

 - 00 0000   SOL ../../../../gfx/layers/IPC/ShadowLayers.h

now when some file in gfx/layers/ipc does

#include "ShadowLayres.h"

the file found is the local one with the lowercase directory name and we end up with

 - 00 0000   SOL ../../../../gfx/layers/ipc/ShadowLayers.h

Cutting one symbol is probably insignificant, but making our builds more reproducible is not. I found this while trying to figure out why a build done on try gets better scores on dromaeo than one done locally on the same OS, with same xcode and clang. This is probably not it, but any differences in the binaries helps hide the problem.
Attachment #655863 - Flags: review?(ted.mielczarek)
Comment on attachment 655863 [details] [diff] [review]
s/IPC/ipc/

Review of attachment 655863 [details] [diff] [review]:
-----------------------------------------------------------------

Crazy!
Attachment #655863 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/468a7e985d82
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.