Closed
Bug 786154
Opened 13 years ago
Closed 13 years ago
enable FAIL_ON_WARNINGS in /netwerk/cache
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
Details
Attachments
(1 file, 1 obsolete file)
|
2.05 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
I didn't try to dig too deep to figure out if we should report errors back up to callers (as my patch does) or always report NS_OK (as current code does). Reporting failure does change the behavior of one of the callers.
Attachment #655876 -
Flags: review?(michal.novotny)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 655876 [details] [diff] [review]
v1
I think we should return NS_OK. Returning failure fires another timer to retry the operation, but failures of WriteCacheClean() are IMO fatal (i.e. another try will fail too).
|
Assignee | |
Comment 2•13 years ago
|
||
Assignee: nobody → jduell.mcbugs
Attachment #655876 -
Attachment is obsolete: true
Attachment #655876 -
Flags: review?(michal.novotny)
Attachment #656761 -
Flags: review?(michal.novotny)
|
|
||
Updated•13 years ago
|
Attachment #656761 -
Flags: review?(michal.novotny) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7af99eb7bd5
Note: the warning this fixed went away since +r, so this is now just a matter of setting FAIL_ON_WARNINGS in the netwerk/cache/Makefile.in
Summary: Fix last warning in cache so we can enable FAIL_ON_WARNINGS → enable FAIL_ON_WARNINGS in /netwerk/cache
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•