78629 - [console] dom must not print to console for opt builds

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[cls]

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>

Comment 1

[cls]

Attachment: prelim patch

Comment 2

[Johnny Stenback (:jst)]

The output we get from GlobalWindowImpl::Dump() will be controlled by a pref
(see bug 74816), so please don't check in that change. I'm ok with the changing
nsJSEnvironment.cpp, but why not put the whole errorStr and the if block inside
#ifdef NS_DEBUG, if we're not gonna print the error string, why bother
allocating and copying the string?

Comment 3

[cls]

Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 4

[Jon Granrose]

bug depending on this is 0.9.1

Comment 5

[Johnny Stenback (:jst)]

I checked in a fix for the fprintf in nsJSEnvironment.cpp, the other printf in
the DOM is coverd by bug 74816, marking fixed.

Comment 6

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 7

[Sivakiran Tummala]

verified that this bug is a duplicate of bug number 76720..
marking as verfied