Closed
Bug 786359
Opened 13 years ago
Closed 13 years ago
Missing #ifndef/#endif in netwerk/dns/nsDNSService2.h
Categories
(Core :: Networking: DNS, defect)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: valentin, Assigned: valentin)
References
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
The #ifndef directive should be added
|
Assignee | |
Comment 1•13 years ago
|
||
Added the missing directives
|
||
Comment 2•13 years ago
|
||
Comment on attachment 656097 [details] [diff] [review]
Fix v1.0
Review of attachment 656097 [details] [diff] [review]:
-----------------------------------------------------------------
thanks!
make sure to run it through try before pushing
Attachment #656097 -
Flags: review?(mcmanus) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Appears to be building and running just fine:
https://tbpl.mozilla.org/?tree=Try&rev=c7b0e10785c5
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
(In reply to Valentin Gosu from comment #3)
> https://tbpl.mozilla.org/?tree=Try&rev=c7b0e10785c5
Green on Try.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f70ebe7aad83
Thanks for the patch, Valentin! One request - to make life easier for those committing on your behalf, please make sure that your future patches have all the necessary hg metadata needed for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•