Missing #ifndef/#endif in netwerk/dns/nsDNSService2.h

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: valentin, Assigned: valentin)

Tracking

unspecified
mozilla18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The #ifndef directive should be added
Posted patch Fix v1.0Splinter Review
Added the missing directives
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Attachment #656097 - Flags: review?(mcmanus)
Blocks: 783205
Comment on attachment 656097 [details] [diff] [review]
Fix v1.0

Review of attachment 656097 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

make sure to run it through try before pushing
Attachment #656097 - Flags: review?(mcmanus) → review+
Appears to be building and running just fine:
https://tbpl.mozilla.org/?tree=Try&rev=c7b0e10785c5
Keywords: checkin-needed
(In reply to Valentin Gosu from comment #3)
> https://tbpl.mozilla.org/?tree=Try&rev=c7b0e10785c5

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f70ebe7aad83

Thanks for the patch, Valentin! One request - to make life easier for those committing on your behalf, please make sure that your future patches have all the necessary hg metadata needed for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f70ebe7aad83
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.