Add comments to document the subtleties of nsFrame::Reflow and better document the main dirty frame bits

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla18
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

7 years ago
Spinning this out from bug 734751. I found bz and dbaron's clarifications about how reflow and dirty bits work (both in that bug and on IRC) to be very helpful. This bug is for adding those insights to the code in the form of documentation comments.
Assignee

Comment 1

7 years ago
Posted patch patchSplinter Review
Attachment #656123 - Flags: review?(bzbarsky)
Assignee

Comment 2

7 years ago
Probably I should s/even if no dirty bits are set/even if no dirty bits are set on the children/
Comment on attachment 656123 [details] [diff] [review]
patch

r=me
Attachment #656123 - Flags: review?(bzbarsky) → review+
Assignee

Comment 4

7 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a03f87a931b
Flags: in-testsuite-
Target Milestone: --- → mozilla18
Assignee

Comment 5

7 years ago
(In reply to Jonathan Watt [:jwatt] from comment #2)
> Probably I should s/even if no dirty bits are set/even if no dirty bits are
> set on the children/

Note I tweaked this part of the text for clarification, but not quite as simply as suggested in comment 2.
https://hg.mozilla.org/mozilla-central/rev/5a03f87a931b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.