786406 - Move the tab drag image away from the cursor to prevent it from obscuring the dragged tab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Since we move the tab directly, we don't really need the drag image there, but we still need it for detaching. As a compromise I already made the drag image smaller in bug 783282, but it's still obscuring the tab while dragging, so I suggest we move it a bit away until bug 674925 is done.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 656150 [details] [diff] [review]
patch

Review of attachment 656150 [details] [diff] [review]:
-----------------------------------------------------------------

Do we need to move the drag image horizontally? I think -16px vertical is fine, but I think it can stay in the same horizontal position.

Comment 2

[Dão Gottwald [:dao]]

Moving the image only vertically looks unintended and unreasonable over here.

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70279dff03be

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/70279dff03be

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be605a6e4ade

Comment 6

[u279076]

Could we get a comparative screenshot so we have a clearer idea of what to look out for in verification of this fix? Thanks.

Comment 7

[Dão Gottwald [:dao]]

The 2012-08-28 nightly should have the unpatched behavior. I don't have a screenshot.

Comment 8

[u279076]

Okay, thanks Dao.

Comment 9

[Virgil Dicu [:virgil] [QA]]

For the
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120827030549
the dragged image near cursor obscures the dragged tab.

As for
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 beta 4
Build ID: 20121031065642
the dragged image is smaller and is set away from the cursor.

Comment 10

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old