Closed Bug 786412 Opened 7 years ago Closed 6 years ago

Consolidate ContainerLayer functions

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: cwiiis, Assigned: nrc)

Details

Attachments

(1 file, 1 obsolete file)

The code in the different implementations of ContainerLayer for InsertAfter and RemoveChild is actually identical (or at least, it will be after bug 785333) - we should consolidate this instead of copy-pasting.
Try looks good and it's a nice reduction.

I wonder if we can do anything with ComputeEffectiveTransform?
Attachment #662136 - Flags: review?(bas.schouten)
I guess this may be obsoleted by nrc's shadow layers work?

Will hold off on doing anything else - just a note to self, is it ok that BasicShadowableRefLayer uses ContainerComputeEffectiveTransforms instead of DefaultComputeEffectiveTransforms(?)
Comment on attachment 662136 [details] [diff] [review]
Move child add/remove functions to ContainerLayer

Review of attachment 662136 [details] [diff] [review]:
-----------------------------------------------------------------

This patch is obsoleted I think because of Nick's work, although it's certainly a good idea in general.
Attachment #662136 - Flags: review?(bas)
We should totally do this after the refactoring lands, I do something similar, so it should be easier then too.
Nick, can this bug be closed, or can I assign it to you?
Flags: needinfo?(ncameron)
assign it to me is fine, I'll check how this tands in the refactoring and apply your patch if we can.
Flags: needinfo?(ncameron)
Cool, thanks :)
Assignee: chrislord.net → ncameron
So, I think I'll leave this until after the refactoring lands. I'm pretty sure it will still work, but it will be a little bit of effort to adjust for composite container layers.
Attachment #662136 - Attachment is obsolete: true
Attachment #796473 - Flags: review?(matt.woodrow)
(In reply to Nick Cameron [:nrc] from comment #8)
> So, I think I'll leave this until after the refactoring lands. I'm pretty
> sure it will still work, but it will be a little bit of effort to adjust for
> composite container layers.

Finally got to this. Removed quite a satisfying amount of copy pasta.
Comment on attachment 796473 [details] [diff] [review]
Sort out container layer methods

Review of attachment 796473 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me assuming it passes tests :)
Attachment #796473 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/45668135bbf4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.