786495 - Dragging a tab to bookmark it or cancelling the drag-and-drop operation (pressing ESC) unexpectedly reorders tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/8af2ff9c6018
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120828030555

Steps to reproduce:
1. Enable Menubar or open Bookmarks Sidebar
2. Open several tabs
3. Drag a tab(To reproduce easily drag last tab)
4. Drag over Bookmarks menu popup or Sidebar after dragging the tab horizontally
5. Press ESC to cancel

Actual results:
 Unexpected reordering tab happens

Expected results:
 Anything should not happen

Comment 1

[Alice0775 White]

Aha, No need trying bookmark,
Just press ESC causes unexpected reordering tab while dragging a tab within the tab strip.

Comment 2

[Alice0775 White]

Aha2,No need press ESC,
Just performed bookmark also causes unexpected reordering tab.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

This makes us move the dragged tab only when actually dropping it on the tab bar. When resetting positions without moving the tab, we also need to make sure the tab is scrolled back into view (via _handleTabSelect).

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4f258315d7c3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f258315d7c3

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be605a6e4ade

Comment 7

[Manuela Muntean [Away]]

Fixed on the latest beta, checked for both MAC and Win 7 64bit:

-> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121023124120

-> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121023124120

Comment 8

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old