Dragging a tab to bookmark it or cancelling the drag-and-drop operation (pressing ESC) unexpectedly reorders tabs

RESOLVED FIXED in Firefox 17

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: alice0775, Assigned: dao)

Tracking

17 Branch
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/8af2ff9c6018
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120828030555

Steps to reproduce:
1. Enable Menubar or open Bookmarks Sidebar
2. Open several tabs
3. Drag a tab(To reproduce easily drag last tab)
4. Drag over Bookmarks menu popup or Sidebar after dragging the tab horizontally
5. Press ESC to cancel

Actual results:
 Unexpected reordering tab happens

Expected results:
 Anything should not happen
(Reporter)

Comment 1

6 years ago
Aha, No need trying bookmark,
Just press ESC causes unexpected reordering tab while dragging a tab within the tab strip.
(Reporter)

Comment 2

6 years ago
Aha2,No need press ESC,
Just performed bookmark also causes unexpected reordering tab.
(Assignee)

Updated

6 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: Trying bookmark by dragging a tab,then press ESC causes unexpected reordering tab → Dragging a tab to bookmark it or cancelling the drag-and-drop operation (pressing ESC) unexpectedly reorders tabs
(Assignee)

Comment 3

6 years ago
Created attachment 657199 [details] [diff] [review]
patch

This makes us move the dragged tab only when actually dropping it on the tab bar. When resetting positions without moving the tab, we also need to make sure the tab is scrolled back into view (via _handleTabSelect).
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #657199 - Flags: review?(jaws)
Attachment #657199 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/4f258315d7c3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Keywords: verifyme
Fixed on the latest beta, checked for both MAC and Win 7 64bit:

-> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121023124120

-> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121023124120
status-firefox17: fixed → verified
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.