Closed Bug 786535 Opened 7 years ago Closed 7 years ago

B2G 3G: Handling roaming setting correctly.

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: jaoo, Assigned: jaoo)

References

Details

Attachments

(1 file, 2 obsolete files)

We're not handling roaming for data calls correctly right now. The user could have internet access in roaming even if she/he doesn't enable it in settings. That's an error that could happen if the user enables data calls while visiting a foreign
network. Actually it's not a regression but an use case that we have not tested properly in the past.
Assignee: nobody → josea.olivera
Blocks: b2g-3g
Attached patch WIP (obsolete) — Splinter Review
This patch could be ready for requesting review right now. I'll test it properly with different ICC cards and request review at Philipp asasp.
Attached patch V1 (obsolete) — Splinter Review
It seems everything is correct now. Tested with a subscriber's SIM inside and outside (roaming) its home network.
Attachment #656306 - Attachment is obsolete: true
Attachment #656441 - Flags: review?(philipp)
Comment on attachment 656441 [details] [diff] [review]
V1

Review of attachment 656441 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +694,5 @@
> +              "or doesn't have data connection.");
> +        return;
> +      }
> +      if (dataInfo.roaming && !this.dataCallSettings["roaming_enabled"]) {
> +        debug("Data connections are not allowed in roaming.");

"We're roaming, but data roaming is disabled."

@@ +703,3 @@
>        RILNetworkInterface.connect(this.dataCallSettings);
>      }
> +    debug("Data call settings: nothing to do.");

Bail out early above:

  if (!this.dataCallSettings["enabled"] || RILNetworkInterface.connected) {
    debug("Data call settings: nothing to do.");
    return;
  }
Attachment #656441 - Flags: review?(philipp) → review+
Attached patch V2Splinter Review
Final version.
Attachment #656441 - Attachment is obsolete: true
Attachment #656965 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/2ff5338aa8c6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.