786535 - B2G 3G: Handling roaming setting correctly.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

We're not handling roaming for data calls correctly right now. The user could have internet access in roaming even if she/he doesn't enable it in settings. That's an error that could happen if the user enables data calls while visiting a foreign
network. Actually it's not a regression but an use case that we have not tested properly in the past.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: WIP

This patch could be ready for requesting review right now. I'll test it properly with different ICC cards and request review at Philipp asasp.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: V1

It seems everything is correct now. Tested with a subscriber's SIM inside and outside (roaming) its home network.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 656441 [details] [diff] [review]
V1

Review of attachment 656441 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +694,5 @@
> +              "or doesn't have data connection.");
> +        return;
> +      }
> +      if (dataInfo.roaming && !this.dataCallSettings["roaming_enabled"]) {
> +        debug("Data connections are not allowed in roaming.");

"We're roaming, but data roaming is disabled."

@@ +703,3 @@
>        RILNetworkInterface.connect(this.dataCallSettings);
>      }
> +    debug("Data call settings: nothing to do.");

Bail out early above:

  if (!this.dataCallSettings["enabled"] || RILNetworkInterface.connected) {
    debug("Data call settings: nothing to do.");
    return;
  }

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: V2

Final version.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff5338aa8c6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ff5338aa8c6