Closed
Bug 786603
Opened 12 years ago
Closed 12 years ago
Readability.js has some coding style inconsistencies
Categories
(Firefox for Android Graveyard :: Reader View, defect, P5)
Tracking
(firefox18 verified)
VERIFIED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox18 | --- | verified |
People
(Reporter: lucasr, Assigned: ande1474)
Details
Attachments
(1 file, 1 obsolete file)
3.38 KB,
patch
|
lucasr
:
review+
jaws
:
feedback+
|
Details | Diff | Splinter Review |
For instance, one-line if's shouldn't have {}'s
Reporter | ||
Updated•12 years ago
|
Priority: -- → P5
Updated•12 years ago
|
Assignee: nobody → ande1474
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
fixed coding style to better match the standards used throughout the rest of the file.
Updated•12 years ago
|
Attachment #659383 -
Attachment is patch: true
Attachment #659383 -
Attachment mime type: application/octet-stream → text/plain
Comment 2•12 years ago
|
||
Michael, can you generate a diff of your changes and upload your diff to this bug? Ask for help in #introduction if you are confused.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #659746 -
Flags: review?(lucasr.at.mozilla)
Attachment #659746 -
Flags: review?(jaws)
Updated•12 years ago
|
Attachment #659383 -
Attachment is obsolete: true
Comment 4•12 years ago
|
||
Comment on attachment 659746 [details] [diff] [review] Patch file for my changes. This looks good to me. I marked this feedback+ (and not review+), because I'd still like Lucas to take a look at the patch to make sure everything is accounted for. Tip: When uploading a file, mark 'obsolete' the older versions of the patch and check the 'patch' checkbox if the attachment is a patch for the bug.
Attachment #659746 -
Attachment is patch: true
Attachment #659746 -
Flags: review?(jaws) → feedback+
Reporter | ||
Updated•12 years ago
|
Attachment #659746 -
Flags: review?(lucasr.at.mozilla) → review+
Updated•12 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 5•12 years ago
|
||
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/af6c294d2bc7
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/af6c294d2bc7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Comment 7•12 years ago
|
||
The corrections were applied on the latest Nightly. Closing bug as verified fixed on: Firefox 18.0a1 (2012-09-19) Device: Galaxy Note OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18:
--- → verified
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•