Readability.js has some coding style inconsistencies

VERIFIED FIXED in Firefox 18

Status

()

Firefox for Android
Reader View
P5
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: Michael Anderson)

Tracking

Trunk
Firefox 18
All
Android
Points:
---

Firefox Tracking Flags

(firefox18 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
For instance, one-line if's shouldn't have {}'s
(Reporter)

Updated

5 years ago
Priority: -- → P5
Assignee: nobody → ande1474
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 659383 [details] [diff] [review]
file to be fixed

fixed coding style to better match the standards used throughout the rest of the file.
Attachment #659383 - Attachment is patch: true
Attachment #659383 - Attachment mime type: application/octet-stream → text/plain
Michael, can you generate a diff of your changes and upload your diff to this bug? Ask for help in #introduction if you are confused.
(Assignee)

Comment 3

5 years ago
Created attachment 659746 [details] [diff] [review]
Patch file for my changes.
Attachment #659746 - Flags: review?(lucasr.at.mozilla)
Attachment #659746 - Flags: review?(jaws)
Attachment #659383 - Attachment is obsolete: true
Comment on attachment 659746 [details] [diff] [review]
Patch file for my changes.

This looks good to me. I marked this feedback+ (and not review+), because I'd still like Lucas to take a look at the patch to make sure everything is accounted for.

Tip: When uploading a file, mark 'obsolete' the older versions of the patch and check the 'patch' checkbox if the attachment is a patch for the bug.
Attachment #659746 - Attachment is patch: true
Attachment #659746 - Flags: review?(jaws) → feedback+
(Reporter)

Updated

5 years ago
Attachment #659746 - Flags: review?(lucasr.at.mozilla) → review+
Keywords: checkin-needed
(Reporter)

Comment 5

5 years ago
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/af6c294d2bc7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/af6c294d2bc7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
The corrections were applied on the latest Nightly. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-19)
Device: Galaxy Note
OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18: --- → verified
You need to log in before you can comment on or make changes to this bug.