786675 - test_pc_offer.js and test_pc_answer.js xpcshell tests are perma-orange

Status: RESOLVED INCOMPLETE

(Core :: WebRTC: Networking, defect)

Description

[(not currently active) Ted Mielczarek]

Looks like a similar failure mode in both tests:
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/head.js | [Exception... "Could not convert JavaScript argument arg 1 [IPeerConnection.initialize]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/tests/dom/media/tests/unit/test_pc_offer.js :: createOffer :: line 45"  data: no] - See following stack:
JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 451
JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: _run_next_test :: line 899
JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: <TOP_LEVEL> :: line 418

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/head.js | [Exception... "Could not convert JavaScript argument arg 1 [IPeerConnection.initialize]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/tests/dom/media/tests/unit/test_pc_answer.js :: createOfferAnswer :: line 80"  data: no] - See following stack:
JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 451
JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: _run_next_test :: line 899
JS frame :: /Users/cltbld/talos-slave/test/build/xpcshell/head.js :: <TOP_LEVEL> :: line 418

Comment 1

[(not currently active) Ted Mielczarek]

Apparently bug 733002 broke this by adding a window parameter to IPeerConnection::initialize:
http://hg.mozilla.org/projects/alder/rev/8b8647e401a6

Comment 2

[(not currently active) Ted Mielczarek]

The naive fix here, passing null for the window parameter, doesn't work:

WARNING: NS_ENSURE_TRUE(mWindow) failed: file /build/alder/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp, line 394

TEST-UNEXPECTED-FAIL | /build/alder/testing/xpcshell/head.js | [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [IPeerConnection.initialize]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: /build/debug-alder/_tests/xpcshell/dom/media/tests/unit/test_pc_offer.js :: createOffer :: line 45"  data: no] - See following stack:
JS frame :: /build/alder/testing/xpcshell/head.js :: do_throw :: line 451
JS frame :: /build/alder/testing/xpcshell/head.js :: _run_next_test :: line 899
JS frame :: /build/alder/testing/xpcshell/head.js :: <TOP_LEVEL> :: line 418

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: PeerConnectionImpl xpcshell tests need a window arg (and don't have a window)

Comment 4

[(not currently active) Ted Mielczarek]

I marked these tests as known-fail for the time being, so we'll still run them but the tree won't be orange:
http://hg.mozilla.org/projects/alder/rev/c0366bca6309