Closed Bug 786686 Opened 10 years ago Closed 10 years ago

B2G Contacts API must not access RadioInterfaceLayer in content process

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(1 file)

The error message is:

E/GeckoConsole( 1714): [JavaScript Error: "NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 27}]
blocking-basecamp: --- → ?
Hm did anything change in the mozilla.org/telephony/system-worker-manager?

All I do is:

XPCOMUtils.defineLazyGetter(this, "mRIL", function () {
  return Cc["@mozilla.org/telephony/system-worker-manager;1"].getService(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIRadioInterfaceLayer);
});
Err, ContactManager.js lives in the content process, right? You don't have the SystemWorkerManager or RadioInterfaceLayer there.
(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> Err, ContactManager.js lives in the content process, right? You don't have
> the SystemWorkerManager or RadioInterfaceLayer there.

Ah Contacts is now OOP. That makes sense. Thx!
I don't think Contacts is going back in-process so marking as a blocker.
blocking-basecamp: ? → +
Assignee: nobody → anygregor
Summary: B2G: ContactManager.js cannot get RadioInterfaceLayer → B2G Contacts API must not access RadioInterfaceLayer in content process
Yoshi started working on it. Thanks Yoshi!
Assignee: anygregor → allstars.chh
Attached patch PatchSplinter Review
Hi, Gregor
Can you give me some feedback for my patch?

Thanks
Attachment #657300 - Flags: feedback?(anygregor)
Comment on attachment 657300 [details] [diff] [review]
Patch

Hi, Gregor
Can you review this patch for me?

Also if there is error happened when getICCContacts, (i.e. SIM is not inserted)
the callback would still be called,
as I address this in Bug 786694 Part 2.

Thank you :)
Attachment #657300 - Flags: feedback?(anygregor) → review?(anygregor)
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #7)
> Comment on attachment 657300 [details] [diff] [review]
> Patch
> 
> Hi, Gregor
> Can you review this patch for me?
> 
> Also if there is error happened when getICCContacts, (i.e. SIM is not
> inserted)
> the callback would still be called,
> as I address this in Bug 786694 Part 2.
> 
> Thank you :)

Could we expose this info (no sim card) with an error callback?
(In reply to Gregor Wagner [:gwagner] from comment #8) 
> Could we expose this info (no sim card) with an error callback?

Sure, I'll file another bug for this and take it.
Attachment #657300 - Flags: review?(anygregor) → review+
Target Milestone: --- → mozilla18
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #9)
> (In reply to Gregor Wagner [:gwagner] from comment #8) 
> > Could we expose this info (no sim card) with an error callback?
> 
> Sure, I'll file another bug for this and take it.

File Bug 787477 for this.
https://hg.mozilla.org/mozilla-central/rev/6ccd54887d19
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1157082
You need to log in before you can comment on or make changes to this bug.