786686 - B2G Contacts API must not access RadioInterfaceLayer in content process

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The error message is:

E/GeckoConsole( 1714): [JavaScript Error: "NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" {file: "jar:file:///system/b2g/omni.ja!/components/ContactManager.js" line: 27}]

Comment 1

[Gregor Wagner [:gwagner]]

Hm did anything change in the mozilla.org/telephony/system-worker-manager?

All I do is:

XPCOMUtils.defineLazyGetter(this, "mRIL", function () {
  return Cc["@mozilla.org/telephony/system-worker-manager;1"].getService(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIRadioInterfaceLayer);
});

Comment 2

[Philipp von Weitershausen [:philikon]]

Err, ContactManager.js lives in the content process, right? You don't have the SystemWorkerManager or RadioInterfaceLayer there.

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> Err, ContactManager.js lives in the content process, right? You don't have
> the SystemWorkerManager or RadioInterfaceLayer there.

Ah Contacts is now OOP. That makes sense. Thx!

Comment 4

[Andrew Overholt [:overholt]]

I don't think Contacts is going back in-process so marking as a blocker.

Comment 5

[Gregor Wagner [:gwagner]]

Yoshi started working on it. Thanks Yoshi!

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Hi, Gregor
Can you give me some feedback for my patch?

Thanks

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 657300 [details] [diff] [review]
Patch

Hi, Gregor
Can you review this patch for me?

Also if there is error happened when getICCContacts, (i.e. SIM is not inserted)
the callback would still be called,
as I address this in Bug 786694 Part 2.

Thank you :)

Comment 8

[Gregor Wagner [:gwagner]]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #7)
> Comment on attachment 657300 [details] [diff] [review]
> Patch
> 
> Hi, Gregor
> Can you review this patch for me?
> 
> Also if there is error happened when getICCContacts, (i.e. SIM is not
> inserted)
> the callback would still be called,
> as I address this in Bug 786694 Part 2.
> 
> Thank you :)

Could we expose this info (no sim card) with an error callback?

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Gregor Wagner [:gwagner] from comment #8) 
> Could we expose this info (no sim card) with an error callback?

Sure, I'll file another bug for this and take it.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ccd54887d19

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #9)
> (In reply to Gregor Wagner [:gwagner] from comment #8) 
> > Could we expose this info (no sim card) with an error callback?
> 
> Sure, I'll file another bug for this and take it.

File Bug 787477 for this.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ccd54887d19