78669 - [console] xpinstall must not print to console in opt builds

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[cls]

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>

Comment 1

[cls]

Attachment: prelim patch

Comment 2

[cls]

Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 3

[Jon Granrose]

76720 is targetted for 0.9.1, setting same.

Comment 4

[Daniel Veditz [:dveditz]]

Note that the fprintf in the unix wizard is actually correct, and it's 
something the command-line installer prints not mozilla itself. The other two 
should go, however.

Comment 5

[Daniel Veditz [:dveditz]]

oh yeah, don't set the target milestone for other folks.

The patch keyword helps with visibility though

Comment 6

[chris hofmann]

lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.

Comment 7

[Blake Ross]

Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone.  Please correct if I'm mistaken.

Comment 8

[Daniel Veditz [:dveditz]]

I've had the patch in my tree forever, taking bug

Comment 9

[Daniel Veditz [:dveditz]]

Checked in

Comment 10

[Jimmy Lee]

No print to console.  Marking Verified.