Fix buffered streams when outputting 16bit

RESOLVED FIXED in Firefox 17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

({qawanted})

unspecified
mozilla18
qawanted
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 656461 [details] [diff] [review]
Fix buffered streams on 16 bit outputs
Attachment #656461 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #656461 - Flags: review? → review?(kinetik)
Attachment #656461 - Flags: review?(kinetik) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5071c1a3c394
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/5071c1a3c394
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 3

5 years ago
Comment on attachment 656461 [details] [diff] [review]
Fix buffered streams on 16 bit outputs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 775319
User impact if declined: garbled/no audio, may crash with some players
Testing completed (on m-c, etc.): already in Aurora with no issues; by me on cubeb/alsa with youtube/html5 player using freebsd where float32 doesn't work (bug 780531)
Risk to taking this patch (and alternatives if risky): none for float32, garbled/no audio for s16 (e.g. on android)
Attachment #656461 - Flags: approval-mozilla-beta?

Comment 4

5 years ago
We'll approve this, but we need to make sure we didn't regress Firefox for Android. Can you provide some example streams for QA to test?
Keywords: qawanted, verifyme
QA Contact: aaron.train

Updated

5 years ago
Attachment #656461 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 5

5 years ago
(In reply to Alex Keybl [:akeybl] from comment #4)
> We'll approve this, but we need to make sure we didn't regress Firefox for
> Android. Can you provide some example streams for QA to test?

Firefox for Android doesn't use this code path at all. Otherwise, it would've been discovered and fixed long ago. Firefox for Android uses sydneyaudio while this code path is for cubeb.

When this bug is triggered, the audio output is mostly noise. No special example streams are necessary.
(Assignee)

Comment 6

5 years ago
(In reply to Jan Beich from comment #3)
> Comment on attachment 656461 [details] [diff] [review]
> Fix buffered streams on 16 bit outputs
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): bug 775319
> User impact if declined: garbled/no audio, may crash with some players
> Testing completed (on m-c, etc.): already in Aurora with no issues; by me on
> cubeb/alsa with youtube/html5 player using freebsd where float32 doesn't
> work (bug 780531)
> Risk to taking this patch (and alternatives if risky): none for float32,
> garbled/no audio for s16 (e.g. on android)

Are you going to land it or will you need someone to land it for you?

Comment 7

5 years ago
(In reply to Michael Wu [:mwu] from comment #6)
> Are you going to land it or will you need someone to land it for you?

No, I have zero commit access. Please, land it to 17.0.

Updated

5 years ago
QA Contact: aaron.train
https://hg.mozilla.org/releases/mozilla-beta/rev/6cfacf221d96
status-firefox17: --- → fixed
status-firefox18: --- → fixed
Flags: in-testsuite-
Is there anything specific that we can do here to verify this bug? See comment 4.
(Assignee)

Comment 10

5 years ago
(In reply to Virgil Dicu [:virgil] [QA] from comment #9)
> Is there anything specific that we can do here to verify this bug? See
> comment 4.

This bug never existed on any of our tier 1 platforms. It sounds like testing firefox on freebsd might do the trick but I dunno if there's any special configuration required to enable cubeb/alsa.
I was not able to verify this due to lack of resources and system configuration.

Michael, can you please verify if this is fixed?
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.