786691 - Do not display the (more flags) link to logged out users as they cannot set any flag

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

While browsing Bugzilla as a logged out user, I realized that the (more flags) link was displayed in bug reports. But as I cannot edit nor set any flag, clicking on it has no effect. The link simply disappears. This is confusing. We should have a [% IF user.id %] somewhere in the template to only display this link if the user is logged in.

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to hide more/set flags links for logged out users (v1)

Comment 2

[Frédéric Buclin]

Comment on attachment 656490 [details] [diff] [review]
Patch to hide more/set flags links for logged out users (v1)

>-        [% IF show_more_flags %]
>+        [% IF show_more_flags && user.id %]

This is not the right place to fix the code. The JS code won't be able to access bz_flags_more_container. You should rather check that the user is logged in before setting show_more_flags = 1. This way, you will fix both places at once.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to hide more/set flags links for logged out users (v2)

Comment 4

[Frédéric Buclin]

Comment on attachment 656891 [details] [diff] [review]
Patch to hide more/set flags links for logged out users (v2)

r=LpSolit

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified template/en/default/bug/edit.html.tmpl
Committed revision 8368.