786703 - fix dom/ build failures from introducing PARALLEL_DIRS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nathan Froyd [:froydnj]]

I received this error this morning:

xpidl.IDLError: error: File 'domstubs.idl' not found, ../../../dist/idl/nsIDOMEvent.idl line 6:0
#include "domstubs.idl"
make[4]: *** [_xpidlgen/nsIDOMLSProgressEvent.h] Error 1
make[4]: *** Deleting file `_xpidlgen/nsIDOMLSProgressEvent.h'
make[3]: *** [interfaces/load-save_export] Error 2
make[3]: *** Waiting for unfinished jobs....

This failure indicates a bug in my algorithm to fix bug 783357: it's not enough to say:

- what are the includes for all files in this directory?
- where are those includes located?
- ...and add those directories to XPIDL_FLAGS

nsIDOMLSProgressEvent.idl includes nsIEvent.idl, but the above algorithm fails to note that we also need to consider what -I flags nsIEvent.idl would need.  What you really need to do is iterate step 1 until you get *all* the files included by a given file.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Patch as requested.  Should fix the idl build failures seen sporadically.

Comment 2

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a36a323e347e

Comment 3

[Christian Holler (:decoder)]

Confirmed that this fixes the build failures on try =)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a36a323e347e