786750 - upstream opus support at webrtc.org

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Attachment: patch against webrtc.org

Bug 694810 was getting long, and opus webrtc support has landed on the alder project branch. I opened this bug to separately track preparation of an upstream patch against the webrtc.org codebase.

Comment 1

[Ralph Giles (:rillian)]

Attachment: patch against webrtc.org

Updated patch.

 - set the bitrate from the CodecInst params when the encoder is created.
 - roundtrip data through Opus as part of audio_codec_module_test

Comment 2

[Ralph Giles (:rillian)]

Attachment: patch against webrtc.org

Updated patch against webrtc.org svn r2712.

- Fixes an && vs || typo
- Run the Encoder at native 48 kHz, only the receive side needs resampling
- Gyp fixes to build under xcode.

I've verified this version round-trips audio with the opus codec selected using voe_cmd_test on MacOS X. The test doesn't work for me on Linux, including with G.711 and an unpatched build, so I think there's something wrong with the audio_device support on linux.

Comment 3

[Ralph Giles (:rillian)]

A heavily modified version of this patch landed upstream.

Initial support, disabled at compile time:
https://code.google.com/p/webrtc/source/detail?r=2945

Subsequent integration and build enable for chrome:
https://code.google.com/p/webrtc/source/detail?r=2953
https://code.google.com/p/webrtc/source/detail?r=2964
https://code.google.com/p/webrtc/source/detail?r=2982
https://code.google.com/p/webrtc/source/detail?r=2984
https://code.google.com/p/webrtc/source/detail?r=2990
https://code.google.com/p/webrtc/source/detail?r=2993
https://code.google.com/p/webrtc/source/detail?r=2997
https://code.google.com/p/webrtc/source/detail?r=3012