786756 - Expose exposure controls through camera API

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

When comparing otoro to another phone that uses the same chipset, mwu noticed that the other phone's image quality was appreciably better.  The otoro preview stream seems blown out in comparison.  We should ensure the initial settings we choose maximize quality.  This should also incidentally boost framerate, since that's proportional to exposure time.

A related issue here is that we should be initializing camera parameters to consistent defaults across all devices.  It may be that the same parameters result in different exposure values, but that would be good to know.  We could set up device-specific initial settings to work around that.

Comment 1

[Johnny Stenback (:jst)]

Blocking based on discussion with clee, and over to mikeh who will either work on this or reassign to a better owner.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

The camera has a dazzling array of frobs we can, uh, frob to fix this.  I'll look into it and see if any are already exposed to or worth exposing to the DOM.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: WIP - expose saturation, sharpness, and contrast to CameraControl

The CameraCapabilities object exposes maxSaturation, maxSharpness, and maxContrast attributes, which can be used to twiddle the respective settings on CameraControl.

Camera app support needed; I haven't tested this patch yet, but it builds and shouldn't break anything else, so go ahead.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: apps/camera/index.html - adds new controls

Add controls to twiddle exposure compensation, contrast, saturation, and sharpness.  Some pretty gruesome results as possible.  Forthcoming JS and CSS are required.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: apps/camera/index.html - adds new controls

(The right file, this time.)

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: apps/camera/style/camera.css

Style sheet.

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: apps/camera/js/camera.js

Javascript

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: WIP - expose saturation, sharpness, and contrast to CameraControl

New version of the patch.  It seems the Otoro exposure compensation API expects real EVs instead of the indexed values described in CameraParameters.h.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: WIP - expose contrast, saturation, sharpness, MCE, and ISO sensitivity to CameraControl

Everything that's in the previous version of this patch, plus MCE support and ISO sensitivity support:

E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:352 in gotCamera: Supported memory colour enhancement modes:
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:354 in gotCamera:   - enable
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:354 in gotCamera:   - disable
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:365 in gotCamera: Supported ISO modes:
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - auto
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - ISO_HJR
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - ISO100
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - ISO200
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - ISO400
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - ISO800
E/GeckoConsole( 4865): Content JS LOG at app://camera.gaiamobile.org/js/camera.js:367 in gotCamera:   - ISO1600

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: apps/camera/js/camera.js

Everything that was in the previous version, plus this automatically toggles MCE once per second--not that I can see it doing anything.

This version doesn't do anything with the ISO setting except log supported values.

Anyone know what "ISO_HJR" is?  Google draws a blank.

Comment 11

[Mike Habicher [:mikeh] (high bugzilla latency)]

mwu: on the devices you were comparing Otoro to, can you grab a logcat to compare to the Otoro's?

Comment 12

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Mike Habicher [:mikeh] from comment #10)
> 
> Everything that was in the previous version, plus this automatically toggles
> MCE once per second--not that I can see it doing anything.

Note that it's possible MCE only affects the final image, not the preview.  Further experimentation required.

Comment 13

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Patch for camera app to expose ExpComp, Contrast, Saturation, and Sharpness

Patch is based on gaia/apps/camera.

Comment 14

[Mike Habicher [:mikeh] (high bugzilla latency)]

Hmm, turning MCE on/off (it seems to default to 'on' on Otoro) doesn't show any visible difference, though currently I've only tested it with pictures of white buildings under overcast skies, and with pictures of images on my monitor.

Need some more interesting light to test with.

Comment 15

[Alex Keybl [:akeybl]]

Doesn't appear to be occurring on the Unagi phones. No longer blocking.

Comment 16

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Morph.

Comment 17

[BMO Automation]

Firefox OS is not being worked on